[Bug 30488] New: Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Bug ID: 30488 Summary: Recalls for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P1 - high Component: OPAC Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: adussert@pacifica.edu, aleisha@catalyst.net.nz, alexbuckley@catalyst.net.nz, andrew@bywatersolutions.com, arthur.suzuki@biblibre.com, baselibrary.consortium@nhs.net, bob@calyx.net.au, bolshawh@parliament.uk, boutrosboutrosboutros@gmail.com, brendan@bywatersolutions.com, chris@bigballofwax.co.nz, clopez@dml.vic.edu.au, david@davidnind.com, dcook@prosentient.com.au, dpavlin@rot13.org, fridolin.somers@biblibre.com, gmcharlt@gmail.com, hannah.co@northwestu.edu, hc@interleaf.ie, hughr@brimbank.vic.gov.au, jonathan.druart+koha@gmail.com, katrin.fischer@bsz-bw.de, kelly@bywatersolutions.com, kyle@bywatersolutions.com, liz@catalyst.net.nz, m.de.rooy@rijksmuseum.nl, marjorie.barry-vila@collecto.ca, martin.renvoize@ptfs-europe.com, niamh.walker-headon@it-tallaght.ie, nick@bywatersolutions.com, pasi.kallinen@koha-suomi.fi, paul.thornton@educampus.ie, testopia@bugs.koha-community.org, tomascohen@gmail.com, victor@tuxayo.net Depends on: 19532 I'm getting an error when placing a recall from the OPAC. It appears at the last stage, after clicking the submit button to place the recall. Validation failed for type named Month declared in package DateTime::Types (/usr/lib/x86_64-linux-gnu/perl5/5.28/DateTime/Types.pm) at line 119 in sub named (eval) with value 29 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Recalls for Koha |Error when placing a recall | |in the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|adussert@pacifica.edu, | |andrew@bywatersolutions.com | |, | |arthur.suzuki@biblibre.com, | |baselibrary.consortium@nhs. | |net, bob@calyx.net.au, | |bolshawh@parliament.uk, | |boutrosboutrosboutros@gmail | |.com, | |brendan@bywatersolutions.co | |m, | |chris@bigballofwax.co.nz, | |clopez@dml.vic.edu.au, | |david@davidnind.com, | |dcook@prosentient.com.au, | |dpavlin@rot13.org, | |gmcharlt@gmail.com, | |hannah.co@northwestu.edu, | |hc@interleaf.ie, | |hughr@brimbank.vic.gov.au, | |kelly@bywatersolutions.com, | |kyle@bywatersolutions.com, | |liz@catalyst.net.nz, | |m.de.rooy@rijksmuseum.nl, | |marjorie.barry-vila@collect | |o.ca, | |martin.renvoize@ptfs-europe | |.com, | |niamh.walker-headon@it-tall | |aght.ie, | |nick@bywatersolutions.com, | |pasi.kallinen@koha-suomi.fi | |, | |paul.thornton@educampus.ie, | |testopia@bugs.koha-communit | |y.org, | |tomascohen@gmail.com, | |victor@tuxayo.net | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 133095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133095&action=edit Bug 30488: Fix error when placing recall via OPAC This error occurs due to how UpdateStats is called in Koha/Recalls.pm To test: 1) Enable the UseRecalls system preference and set some random values in the recalls circulation and fines rules. 2) Find or create an item. Check this item out to Patron A. 3) Log in to the OPAC as Patron B. 4) Find the item you checked out to Patron A. Click the button to place a recall. 5) Fill out whatever details you like. Click the Submit button. This should trigger the error. 6) Apply the patch and refresh the page. 7) Confirm the recall has now been requested successfully. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133095|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133148&action=edit Bug 30488: Fix error when placing recall via OPAC This error occurs due to how UpdateStats is called in Koha/Recalls.pm To test: 1) Enable the UseRecalls system preference and set some random values in the recalls circulation and fines rules. 2) Find or create an item. Check this item out to Patron A. 3) Log in to the OPAC as Patron B. 4) Find the item you checked out to Patron A. Click the button to place a recall. 5) Fill out whatever details you like. Click the Submit button. This should trigger the error. 6) Apply the patch and refresh the page. 7) Confirm the recall has now been requested successfully. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #0)
I'm getting an error when placing a recall from the OPAC. It appears at the last stage, after clicking the submit button to place the recall.
Validation failed for type named Month declared in package DateTime::Types (/usr/lib/x86_64-linux-gnu/perl5/5.28/DateTime/Types.pm) at line 119 in sub named (eval) with value 29
I'm crashing too but the error described does not come up. Instead I see: Use of inherited AUTOLOAD for non-method Koha::Recalls::UpdateStats() is no longer allowed at /usr/share/koha/Koha/Recalls.pm line 168 And this message fits the suggested solution better ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133148|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133341&action=edit Bug 30488: Fix error when placing recall via OPAC This error occurs due to how UpdateStats is called in Koha/Recalls.pm To test: 1) Enable the UseRecalls system preference and set some random values in the recalls circulation and fines rules. 2) Find or create an item. Check this item out to Patron A. 3) Log in to the OPAC as Patron B. 4) Find the item you checked out to Patron A. Click the button to place a recall. 5) Fill out whatever details you like. Click the Submit button. This should trigger the error. 6) Apply the patch and refresh the page. 7) Confirm the recall has now been requested successfully. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Bug 30488 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30488 Bug 30488 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org