[Bug 30291] New: Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Bug ID: 30291 Summary: Rename recalls.* column names Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org The original patchset on bug 19532 replicated what was in the 'reserves' table, and thus introduced several column names that we should better avoid, to adhere to the coding guidelines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hey Tomás Happy to work on this. Can you please advise what changes are to be made? The coding guidelines didn't seem to have what I was looking for https://wiki.koha-community.org/wiki/Coding_Guidelines#Database and the Bug 25260 report is hard to follow. Aleisha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Aleisha Amohia from comment #1)
Hey Tomás
Happy to work on this. Can you please advise what changes are to be made? The coding guidelines didn't seem to have what I was looking for https://wiki.koha-community.org/wiki/Coding_Guidelines#Database and the Bug 25260 report is hard to follow.
Aleisha
Look at the column names here: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123072 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Bug 30291 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132379&action=edit Bug 30291: Database changes to recalls table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132380&action=edit Bug 30291: [DBIx] Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132381&action=edit Bug 30291: [DBIx] Updating boolean flags in Recall schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132382&action=edit Bug 30291: [DBIx] Package fixes in Recall schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132383&action=edit Bug 30291: Changes to tests t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Holds.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132384&action=edit Bug 30291: Changes to controller scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132385&action=edit Bug 30291: Changes to staff client files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132386&action=edit Bug 30291: Changes to OPAC files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Please take a look at the patches and ensure I caught all of the cases, and do a test of the recalls workflows to make sure everything is as normal with the updated column names. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate Severity|enhancement |major CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132385|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132386|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132379|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132382|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134359&action=edit Bug 30291: Database changes to recalls table Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134360&action=edit Bug 30291: Update boolean flags in Recall schema file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134361&action=edit Bug 30291: Changes to tests t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Holds.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/XSLT.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134362&action=edit Bug 30291: Changes to controller scripts Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134363&action=edit Bug 30291: Changes to staff client files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134364&action=edit Bug 30291: Changes to OPAC files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134365&action=edit Bug 30291: Fix permissions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134366&action=edit Bug 30291: (QA follow-up) Keep recall_id column name Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134367&action=edit Bug 30291: Updated schema files [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134359|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134389&action=edit Bug 30291: Database changes to recalls table Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134360|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134390&action=edit Bug 30291: Update boolean flags in Recall schema file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134361|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134391&action=edit Bug 30291: Changes to tests t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Holds.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/XSLT.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134362|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134392&action=edit Bug 30291: Changes to controller scripts Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134363|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134393&action=edit Bug 30291: Changes to staff client files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134364|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134394&action=edit Bug 30291: Changes to OPAC files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134365|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134395&action=edit Bug 30291: Fix permissions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134366|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134396&action=edit Bug 30291: (QA follow-up) Keep recall_id column name Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134367|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134397&action=edit Bug 30291: Updated schema files [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The QA script is happy and this all appears to still be working as expected... so Passing QA. However, building the DBIC Schema appears to spit out lots of overloaded method name errors (at the top as you run the QA script).. I think they're harmless in this case but it's a little disturbing to see. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Passed QA |Failed QA --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- Test suite fails for me : # Failed test 'Recalls tests' # at /kohadevbox/koha/t/db_dependent/Koha/Item.t line 1421. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'id' in 'where clause' at /kohadevbox/koha/C4/Letters.pm line 646 Looks like this is not enought : Bug 30291: (QA follow-up) Keep recall_id column name There are more places with recall_id => id, begining with C4::Letters::_parseletter_sth Maybe squash this revert with main patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134629&action=edit Bug 30291: (QA follow-up) Fix for revert to recall_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134629|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134630&action=edit Bug 30291: (QA follow-up) Fix for revert to recall_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up added to take care of the missing id -> recall_id changes. Beware, the 'DO NOT PUSH' patch contains some changes below the dbic build marker line.. so you'll need to apply those yourself after building the schema.. (or just use the patch and rename the commit message) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 [Bug 30946] Error in database update 21.12.00.048 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Bug 30291 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Bug 30291 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org