[Bug 22560] New: Forgotten password "token expired" page still shows boxes to reset password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Bug ID: 22560 Summary: Forgotten password "token expired" page still shows boxes to reset password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To replicate: Create a user with a username, password, and email defined Attempt to do a forgotten password recovery Munge your token link in whatever way you like (?uniqueKey=$2a$08$B9szbC5lwJd.mh.QznRHZu for example - this one should be invalid in your DB) Note that a yellow "This link is expired" box is shown, but the two password boxes are still there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22561 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86909&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. https://bugs.koha-community.org/show_bug.cgi?id=22520 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86909|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86979&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. https://bugs.koha-community.org/show_bug.cgi?id=22520 Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86979|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86979|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86981&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. https://bugs.koha-community.org/show_bug.cgi?id=22520 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Bug 22560 depends on bug 22561, which changed state. Bug 22561 Summary: Forgotten password requirements hint doesn't list all rules for new passwords https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org