[Bug 18011] New: Categories.pl allows users to set the enrolementperioddate to before the current date without any error /warning messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Bug ID: 18011 Summary: Categories.pl allows users to set the enrolementperioddate to before the current date without any error/warning messages Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P3 Component: System Administration Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com At present when creating a patron category the user can select a date from the date picker which is earlier than the current date, meaning patrons created from the patron category have a dateexpire before they were even created. The fix of this bug is to implement a javascript message informing the user that the date they selected from the datepicker is invalid and forcing them to choose a new date before they can submit the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Check out the options for the datepicker widget which can limit the range of dates which will be accepted. https://jqueryui.com/datepicker/#min-max For instance, in returns.tt starting at line 60. That template also has some back-up date testing in case someone types an invalid date directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|17.05 |master Summary|Categories.pl allows users |Enrollment period date on |to set the |patron category can be set |enrolementperioddate to |in the past without any |before the current date |error/warning messages |without any error/warning | |messages | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid, resetting to master and rephrasing/shortening bug title a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |hayleymapley@catalyst.net.n | |z CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #2)
Still valid, resetting to master and rephrasing/shortening bug title a bit.
I have tried to fix this to no avail. Min-max were specified but did not work. Am resetting to new as someone more familiar with Javascript may wish to have a crack at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleymapley@catalyst.net.n |koha-bugs@lists.koha-commun |z |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87878&action=edit Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages This patch modifies the patron category edit form so that the enrollment period datepicker widget cannot be used to select a date in the past. The <input> element had a "datepicker" class, which triggers a default datepicker configuration. This was overriding the configuration in the page-specific JavaScript file. To test, apply the patch and go to Administration -> Patron categories. Click the "Enrollment period -> Until date" field and verify that dates before today are disabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87878|0 |1 is obsolete| | --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 87935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87935&action=edit Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages This patch modifies the patron category edit form so that the enrollment period datepicker widget cannot be used to select a date in the past. The <input> element had a "datepicker" class, which triggers a default datepicker configuration. This was overriding the configuration in the page-specific JavaScript file. To test, apply the patch and go to Administration -> Patron categories. Click the "Enrollment period -> Until date" field and verify that dates before today are disabled. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87935|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 87973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87973&action=edit Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages This patch modifies the patron category edit form so that the enrollment period datepicker widget cannot be used to select a date in the past. The <input> element had a "datepicker" class, which triggers a default datepicker configuration. This was overriding the configuration in the page-specific JavaScript file. To test, apply the patch and go to Administration -> Patron categories. Click the "Enrollment period -> Until date" field and verify that dates before today are disabled. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org