https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 150180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150180&action=edit Bug 33603: Fix misc/maintenance/search_for_data_inconsistencies.pl when biblio.biblionumber on control field Since bug 29486, misc/maintenance/search_for_data_inconsistencies.pl search for biblio.biblionumber in MARC record with $record->subfield(). This fails when field is a control field (< 10). Idem for biblioitems.biblioitemnumber Test plan : 1.0) On a UNIMARC database (biblio.biblionumber is on 001) 1.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Without patch you get error : Control fields (generally, just tags below 010) do not have subfields, use data() => With patch no error 2.0) On a MARC21 database (biblio.biblionumber is on 999c) 2.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see no error -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150180|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150181&action=edit Bug 33603: Fix misc/maintenance/search_for_data_inconsistencies.pl when biblio.biblionumber on control field Since bug 29486, misc/maintenance/search_for_data_inconsistencies.pl search for biblio.biblionumber in MARC record with $record->subfield(). This fails when field is a control field (< 10). Idem for biblioitems.biblioitemnumber Test plan : 1.0) On a UNIMARC database (biblio.biblionumber is on 001) 1.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Without patch you get error : Control fields (generally, just tags below 010) do not have subfields, use data() => With patch no error 2.0) On a MARC21 database (biblio.biblionumber is on 999c) 2.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see no error Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150181|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150190&action=edit Bug 33603: Fix misc/maintenance/search_for_data_inconsistencies.pl when biblio.biblionumber on control field Since bug 29486, misc/maintenance/search_for_data_inconsistencies.pl search for biblio.biblionumber in MARC record with $record->subfield(). This fails when field is a control field (< 10). Idem for biblioitems.biblioitemnumber Test plan : 1.0) On a UNIMARC database (biblio.biblionumber is on 001) 1.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Without patch you get error : Control fields (generally, just tags below 010) do not have subfields, use data() => With patch no error 2.0) On a MARC21 database (biblio.biblionumber is on 999c) 2.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see no error Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.