[Bug 33560] New: Batch edit link broken if subscriptions are selected using "select all" link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Bug ID: 33560 Summary: Batch edit link broken if subscriptions are selected using "select all" link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When you use the mouse to check checkboxes on the serial search results page, it activates an "Edit selected serials" link which when clicked takes you to the batch edit page. If you use the "Select all" link to check the checkboxes the "Edit selected serials" link is activated but it doesn't work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 [Bug 32698] Use template wrapper for serials pages tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149895&action=edit Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149895|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150112&action=edit Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150112|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150117&action=edit Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org