[Bug 22753] New: Move hold to top button doesn't work if waiting holds exist.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Bug ID: 22753 Summary: Move hold to top button doesn't work if waiting holds exist. Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- On reserve/request.pl, clicking the green up arrow with a bar (the mouseover reads 'Move hold to top') doesn't move a hold up in priority if there is a waiting hold on the bib. This is a regression between 18.05 and 18.11. As a work-around, the change priority drop-down *does* work in 18.11. The 'move hold up', 'move hold down' and 'move hold to bottom' buttons continue to work as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88551&action=edit Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the firs tin the loop, not taking into accoutn waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some cleanmup is done to not display the alter priority arrows for waiting holds To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88551|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88555&action=edit Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the firs tin the loop, not taking into accoutn waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some cleanmup is done to not display the alter priority arrows for waiting holds To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88556&action=edit Bug 22753: (QA follow-up) fixing tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Attachment #88556|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer@bsz-bw.de Summary|Move hold to top button |Move hold to top button |doesn't work if waiting |doesn't work if waiting |holds exist. |holds exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88555|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88641&action=edit Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the first in the loop, not taking into account the waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some clean-up is done to not display the alter priority arrows for waiting holds. To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88642&action=edit Bug 22753: Fix tabs pointed out by QA script Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- not necessary in 18.05.x, won't backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org