[Bug 22743] New: OverDrive results page is missing overdrive-login include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Bug ID: 22743 Summary: OverDrive results page is missing overdrive-login include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88348&action=edit Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88348|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 88371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88371&action=edit Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch reads well, trusting Owen's testing here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88371|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88683&action=edit Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org