[Bug 38876] New: Typo in UpdateNotForLoanStatusOnCheckout description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Bug ID: 38876 Summary: Typo in UpdateNotForLoanStatusOnCheckout description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aude.charillon@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the description of the UpdateNotForLoanStatusOnCheckout system preference, the sentence: "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" should be corrected to "When an item is checked out, if its not for loan value matches the value on the left, then the item's not for loan value will be updated to the value on the right". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #1 from Jessie Zairo <jzairo@bywatersolutions.com> --- Created attachment 189891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189891&action=edit Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3.apply the patch 4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6.Do a reset all and confirm the language is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jzairo@bywatersolutions.com |ity.org | CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189891|0 |1 is obsolete| | --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 189893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189893&action=edit Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3.apply the patch 4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6.Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Great job! looks perfect to me. I hear this is your first patch…awesome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Status|Signed Off |Failed QA --- Comment #4 from David Cook <dcook@prosentient.com.au> --- This looks wonderful, Jessie! This does a great job of updating the system preference description in the UI, and updating description in the database for new Koha installations. Unfortunately, it doesn't update the system preference in the database for existing Koha installations. While users won't be able to notice this, I think that we generally try to keep the database values and the values in sysprefs.sql in sync. I'm sorry but I think I need to mark this as Failed QA! Happy to help you with creating the database upgrade for the missing piece! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189893|0 |1 is obsolete| | --- Comment #5 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 189900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189900&action=edit Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3.apply the patch 4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6.Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #6 from Jessie Zairo <jzairo@bywatersolutions.com> --- Created attachment 190798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190798&action=edit Bug 38876: (QA follow-up) automicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #7 from Jessie Zairo <jzairo@bywatersolutions.com> --- added patch to update the system preference in the database for existing Koha installations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #8 from Jessie Zairo <jzairo@bywatersolutions.com> --- Created attachment 190799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190799&action=edit Bug 38876: (follow-up) fix db rev syntax was wrong for dbrev To test apply patches dbic updatedatatbase koha-mysql kohadev select * from systempreferences where variable='UpdateNotForLoanStatusOnCheckout'; confirm the updated description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189900|0 |1 is obsolete| | Attachment #190798|0 |1 is obsolete| | Attachment #190799|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190899&action=edit Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1. Before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2. Observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3. Apply the patch 4. Navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5. Observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6. Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190900&action=edit Bug 38876: (QA follow-up) automicupdate Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190901&action=edit Bug 38876: (follow-up) fix db rev syntax was wrong for dbrev To test apply patches dbic updatedatatbase koha-mysql kohadev select * from systempreferences where variable='UpdateNotForLoanStatusOnCheckout'; confirm the updated description Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190899|0 |1 is obsolete| | --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191030&action=edit Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1. Before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2. Observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3. Apply the patch 4. Navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5. Observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6. Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190900|0 |1 is obsolete| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191031&action=edit Bug 38876: (QA follow-up) automicupdate Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190901|0 |1 is obsolete| | --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191032&action=edit Bug 38876: (follow-up) fix db rev syntax was wrong for dbrev To test apply patches dbic updatedatatbase koha-mysql kohadev select * from systempreferences where variable='UpdateNotForLoanStatusOnCheckout'; confirm the updated description Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 --- Comment #16 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Minor, lets skip for 25.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- --- Comment #18 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Re-opening, as the sys pref description needs to be updated in the Manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38876 Laure <laure.roy@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |laure.roy@inlibro.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1212 Status|Needs documenting |RESOLVED Documentation| |Laure Roy contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org