[Bug 41141] New: Linker with Elasticsearch fails when heading contains parenthesis or equal sign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 Bug ID: 41141 Summary: Linker with Elasticsearch fails when heading contains parenthesis or equal sign Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org With Elasticsearch, authorities linker fails when heading contains parenthesis or equal sign. Looks like those characters are removed because of CCL syntax but Elasticsearch in this context uses 'ci_raw' form that does not matches if characters are removed. So we should do it only with Zebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 188667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188667&action=edit Bug 41141: Fix linker with Elasticsearch fails when heading contains parenthesis or equal sign With Elasticsearch, authorities linker fails when heading contains parenthesis or equal sign. Looks like those characters are removed because of CCL syntax but Elasticsearch in this context uses 'ci_raw' form that does not matches if characters are removed. So we should do it only with Zebra. Test plan : 1 - Use Elasticsearch 2 - Set sysprefs: RequireChoosingExistingAuthority - don't require AutoCreateAuthorities - generate CatalogModuleRelink - Do AutoLinkBiblio - Do LinkerModule - first match 3 - Find a biblio record with an author attached to an authority 4 - Edit this authority record and add to heading a text with parenthesis, ie '(junior)' 5 - Edit the biblio record in advanced editor 6 - Delete the $9 link 7 - Save the record 8 - It generates a new authority record 10 - Apply patch and restart all 11 - Repeat 4-5 12 - It links to the original authority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm trying to add a UT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Hmm I can't reproduce this one. I'm stuck at the stage of deleting the $9 link in the advanced editor. I erase it but when I click "Save to catalog", it re-creates the linkage to the correct authority: I'm using biblio 134 in KTD where I added (junior) onto the heading: 100 _ _ ‡aHumble, Jez. (junior)‡9926 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Cook from comment #3)
Hmm I can't reproduce this one.
I'm stuck at the stage of deleting the $9 link in the advanced editor. I erase it but when I click "Save to catalog", it re-creates the linkage to the correct authority:
I'm using biblio 134 in KTD where I added (junior) onto the heading:
100 _ _ ‡aHumble, Jez. (junior)‡9926
Hi, thanks for testing. With Elasticsearch ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #4)
Hi, thanks for testing.
No worries. We're almost exclusively using Elasticsearch these days, so always keen to fix ES related bugs.
With Elasticsearch ?
As far as I know I was using it yeah. Could you try again on KTD to reproduce? Maybe I'm just doing the wrong process? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Is step 0 maybe "Have a set of custom ES mappings which include mappings for Match-heading"? The intention of bug 24269 and bug 25273 was to have the Match-heading index be exactly $heading->search_form on the authority field, so it shouldn't matter that the )(= are stripped from the biblio heading since they are also stripped from the authority heading while creating the Match-heading index. But I know from a horrible mislinking bug on my production system with stale vendor-supplied mappings that if you also still have custom Match-heading mappings, you'll get unexpected results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 mageirnaert@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mageirnaert@gmail.com Status|Needs Signoff |Signed Off --- Comment #7 from mageirnaert@gmail.com --- unimarc with the Elastic search engine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This still needs a signoff line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please fill Assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m --- Comment #10 from David Nind <david@davidnind.com> --- Added assignee 8-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org