[Bug 36251] New: Patron search by letter broken in holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Bug ID: 36251 Summary: Patron search by letter broken in holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When placing a hold, if you click on a letter to find the patrons whose last name starts with that letter, it shows all patrons. To recreate: 1. In the staff interface, search for a record 2. Click Place hold 3. Click on a letter under the patron search bar (I used H) --> Patrons with last name starting with another letter are displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35329 CC| |philippe.blouin@inlibro.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried in 23.11 and it's fine. I bisected and found it was due to bug 35329, specifically Bug 35329: Move patron search to modal - funds. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162861&action=edit Bug 36251: (bug 35329 follow-up) Fix patron search by first letter when placing a hold Most of the patrons searches open in a modal. Except: * the main one (members-home) * when placing a hold * when requesting an article (did I miss one?) The patron-search.inc BLOCKs need a parent block to know where to locate the elements (form, table, etc), because we can have several patron searches on the same page. Bug 35329 reused '#searchresults': 10 [% SET search_results_block_id = 'searchresults' %] which is used on the main patron search. The ones in the modal are correctly handled: we build the parent node in the "patron_search_modal" block. But for the 2 others the parent block id is wrong. On reserve/request.tt we have one already, so we set the TT variable from the .tt file On circ/request-article we don't have one already, so we can reuse searchresults (could be more specific however to include 'patrons'...) Test plan: Browse patrons by first letter when placing a hold and requesting an article -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162861|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 162906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162906&action=edit Bug 36251: (bug 35329 follow-up) Fix patron search by first letter when placing a hold Most of the patrons searches open in a modal. Except: * the main one (members-home) * when placing a hold * when requesting an article (did I miss one?) The patron-search.inc BLOCKs need a parent block to know where to locate the elements (form, table, etc), because we can have several patron searches on the same page. Bug 35329 reused '#searchresults': 10 [% SET search_results_block_id = 'searchresults' %] which is used on the main patron search. The ones in the modal are correctly handled: we build the parent node in the "patron_search_modal" block. But for the 2 others the parent block id is wrong. On reserve/request.tt we have one already, so we set the TT variable from the .tt file On circ/request-article we don't have one already, so we can reuse searchresults (could be more specific however to include 'patrons'...) Test plan: Browse patrons by first letter when placing a hold and requesting an article Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Jonathan! Testing note: to test article requests, must enable ArticleRequests syspref. 1. Enable ArticleRequests system preference 2. In the staff interface, search for a record 3. Click Place hold 4. Click on a letter under the patron search bar (I used H) --> Should limit to patrons whose last name start with the letter 5. Go back to the record 6. Click Request Article 7. Click on a letter under the patron search bar (I used H) --> Should limit to patrons whose last name start with the letter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 36284 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162906|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 163038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163038&action=edit Bug 36251: (bug 35329 follow-up) Fix patron search by first letter when placing a hold Most of the patrons searches open in a modal. Except: * the main one (members-home) * when placing a hold * when requesting an article (did I miss one?) The patron-search.inc BLOCKs need a parent block to know where to locate the elements (form, table, etc), because we can have several patron searches on the same page. Bug 35329 reused '#searchresults': 10 [% SET search_results_block_id = 'searchresults' %] which is used on the main patron search. The ones in the modal are correctly handled: we build the parent node in the "patron_search_modal" block. But for the 2 others the parent block id is wrong. On reserve/request.tt we have one already, so we set the TT variable from the .tt file On circ/request-article we don't have one already, so we can reuse searchresults (could be more specific however to include 'patrons'...) Test plan: Browse patrons by first letter when placing a hold and requesting an article Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on bug 35329 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 Bug 36251 depends on bug 35329, which changed state. Bug 35329 Summary: Move patron searches to a modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org