[Bug 16797] New: errors in UNIMARC complet sample authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Bug ID: 16797 Summary: errors in UNIMARC complet sample authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The SQL UNIMARC complet sample authorities fails : installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql Some lines of auth_subfield_structure use an authtypecode not existing in lines of authtypecode : AUTTIT and FA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 [Bug 11586] Better default framework for UNIMARC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 52680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52680&action=edit Bug 16797 - errors in UNIMARC complet sample authorities The SQL UNIMARC complet sample authorities fails : installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql Some lines of auth_subfield_structure use an authtypecode not existing in lines of authtypecode : AUTTIT, SAUT, SCO and STU. Also, I have merged lines refering to authtypecode FA and FAM. Test plan : - On a UNIMARC database : - clear auth tables : mysql> delete from auth_subfield_structure; mysql> delete from auth_tag_structure; mysql> delete from auth_types; - import sql file : mysql < installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql => Without patch you get error : ERROR 1452 (23000) at line 1132: Cannot add or update a child row: a foreign key constraint fails (`koha`.`auth_subfield_structure`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE CASCADE) => With patch no errors :
select distinct(authtypecode) from auth_subfield_structure; +--------------+ | authtypecode | +--------------+ | | | CO | | CO_UNI_TI | | FAM | | GENRE/FORM | | NAME_COL | | NP | | PA | | SAUTTIT | | SNC | | SNG | | TM | | TU | +--------------+ 13 rows in set (0.00 sec)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Feedback: Let's start positive. Nice clean up on the FAM 520 a missing accent. However... 1) Where is FAM 220 j? FA didn't have it, but pre-existing FAM did. 2) Why were the FAM 420/520 x-z descriptions & values replaced with the FA ones? How did you decide which were correct? If you can explain these, I'll sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to M. Tompsett from comment #2) Do you think I should not have merged FAM and FA ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52680|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 52780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52780&action=edit Bug 16797 - errors in UNIMARC complet sample authorities The SQL UNIMARC complet sample authorities fails : installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql Some lines of auth_subfield_structure use an authtypecode not existing in lines of authtypecode : AUTTIT, SAUT, SCO and STU. Test plan : - On a UNIMARC database : - clear auth tables : mysql> delete from auth_subfield_structure; mysql> delete from auth_tag_structure; mysql> delete from auth_types; - import sql file : mysql < installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql => Without patch you get error : ERROR 1452 (23000) at line 1132: Cannot add or update a child row: a foreign key constraint fails (`koha`.`auth_subfield_structure`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE CASCADE) => With patch no errors :
select distinct(authtypecode) from auth_subfield_structure; +--------------+ | authtypecode | +--------------+ | | | CO | | CO_UNI_TI | | FAM | | GENRE/FORM | | NAME_COL | | NP | | PA | | SAUTTIT | | SNC | | SNG | | TM | | TU | +--------------+ 13 rows in set (0.00 sec)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I have removed from patch the FA/FAM part. I will provide a followup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Field 220 : ('FAM', '220', '3', 'Identification autorité', '', 0, 0, -1, '', '', NULL, 0, 0, 0, '', '', ''); ('FAM', '220', '7', 'Écriture de catalogage et écriture de la racine de la vedette', '', 0, 0, -1, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '220', '8', 'Langue de catalogage et langue de la racine de la vedette', '', 0, 0, -1, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '220', 'a', 'Elément d''entrée', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '220', 'f', 'Dates', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '220', 'j', 'Subdivision de forme', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '220', 'x', 'Subdivision de sujet', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '220', 'y', 'Subdivision géographique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '220', 'z', 'Subdivision chronologique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '220', 'a', 'Elément d''entrée', '', 0, 0, 0, '', '', NULL, 0, 0, 0, '', '', ''); ('FA', '220', 'f', 'Dates', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '220', 'x', 'Subdivision de sujet', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '220', 'y', 'Subdivision géographique', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '220', 'z', 'Subdivision chronologique', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); I think we can use everything from FAM lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- ('FAM', '420', 'a', 'Elément d''entrée', '', 0, 0, 0, '', '', NULL, 0, 0, 0, '', '', ''); ('FAM', '420', 'f', 'Dates', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '420', 'j', 'Subdivision de forme', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '420', 'x', 'Subdivision de sujet', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '420', 'y', 'Subdivision géographique', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '420', 'z', 'Subdivision chronologique', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '420', '0', 'Formule introductive', '', 0, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', '2', 'Code du système d''indexation matière', '', 0, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', '3', 'Identificateur de la notice d''autorité', '', 0, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', '5', 'Données codées relatives aux mentions de formes rejetées ou associées 0', '', 0, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', '6', 'Données de lien entre zones', '', 0, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', '7', 'Ecriture de catalogage et écriture de la racine de la vedette', '', 0, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', '8', 'Langue de catalogage et langue de la racine de la vedette', '', 0, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', 'a', 'Elément d''entrée', '', 0, 0, 0, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', 'j', 'Subdivision de forme', '', 1, 0, -1, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', 'x', 'Subdiv. de sujet', '', 1, 0, 0, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', 'y', 'Subdiv. géographique', '', 1, 0, 0, '', '', '', NULL, 0, 0, NULL, '', NULL); ('FA', '420', 'z', 'Subdiv. chronologique', '', 1, 0, 0, '', '', '', NULL, 0, 0, NULL, '', NULL); I think we can use all line from FA and 420$f from FAM, not repeatable like 220$f. Last value should be '' instead of NULL, its the column default value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- ('FAM', '520', '5', 'Type de lien', '', 0, 0, 0, '', '', NULL, 0, 0, 0, '', '', ''); ('FAM', '520', '9', 'Numéro autorité koha', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '520', 'a', 'Element d''entrée', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, 'FAM', ''); ('FAM', '520', 'f', 'Dates', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '520', 'j', 'Subdivision de forme', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '520', 'x', 'Subdivision de sujet', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '520', 'y', 'Subdivision géographique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '520', 'z', 'Subdivision chronologique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', '0', 'Formule introductive', '', 0, 0, -1, '', '', NULL, 0, 0, 0, '', '', ''); ('FA', '520', '2', 'Code du système d''indexation matière', '', 0, 0, -1, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', '3', 'Identificateur de la notice d''autorité', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', '5', 'Données codées relatives aux mentions de formes rejetées ou associées 0', '', 0, 0, 0, 'AUT_LIEN', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', '6', 'Données de lien entre zones', '', 0, 0, -1, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', '7', 'Ecriture de catalogage et écriture de la racine de la vedette', '', 0, 0, -1, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', '8', 'Langue de catalogage et langue de la racine de la vedette', '', 0, 0, -1, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', '9', 'N° autorité koha', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', 'a', 'Elément d''entrée', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, 'FA', ''); ('FA', '520', 'j', 'Subdivision de forme', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', 'x', 'Subdiv. de sujet', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', 'y', 'Subdiv. géographique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FA', '520', 'z', 'Subdiv. chronologique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); I think we can use all line from FA and 520$f from FAM, not repeatable like 220$f. FA 520$a contains 'FA' in frameworkcode, I think this is an error it should be empty. 520$5 as a different description in FA and FAM, Id say use FA like in 420$5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- ('FAM', '720', 'a', 'Elément d''entrée', '', 0, 0, 0, '', '', NULL, 0, 0, 0, '', '', ''); ('FAM', '720', 'f', 'Dates', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '720', 'j', 'Subdivision de forme', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '720', 'x', 'Subdivision de sujet', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '720', 'y', 'Subdivision géographique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '720', 'z', 'Subdivision chronologique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); 720 exists only in FAM, use it. Maybe some subfields are missing, 750 as $2 $3 $8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #10 from delaye <stephane.delaye@biblibre.com> --- "I think we can use everything from FAM lines." Ok "I think we can use all line from FA and 420$f from FAM, not repeatable like 220$f. Last value should be '' instead of NULL, its the column default value." Ok "I think we can use all line from FA and 520$f from FAM, not repeatable like 220$f. FA 520$a contains 'FA' in frameworkcode, I think this is an error it should be empty." Ok Add if not exists ('FAM', '720', '2', 'Code du système d\'indexation matière', '', 0, 0, 0, '', '', NULL, 0, 0, 0, '', '', ''); ('FAM', '720', '3', 'Identificateur de la notice d\'autorité', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '720', '7', 'Écriture de catalogage et écriture de la racine de la vedette', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '720', '8', 'Langue de catalogage et langue de la racine de la vedette', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); and ('FAM', '750', '2', 'Code du système d\'indexation matière', '', 0, 0, 0, '', '', NULL, 0, 0, 0, '', '', ''); ('FAM', '720', '3', 'Identificateur de la notice d\'autorité', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '750', '7', 'Écriture de catalogage et écriture de la racine de la vedette', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '750', '8', 'Langue de catalogage et langue de la racine de la vedette', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '750', 'a', 'Elément d''entrée', '', 0, 0, 0, '', '', NULL, 0, 0, 0, '', '', ''); ('FAM', '750', 'f', 'Dates', '', 0, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '750', 'j', 'Subdivision de forme', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '750', 'x', 'Subdivision de sujet', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '750', 'y', 'Subdivision géographique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); ('FAM', '750', 'z', 'Subdivision chronologique', '', 1, 0, 0, '', '', NULL, 0, 0, 0, NULL, '', ''); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Fridolin SOMERS from comment #3)
(In reply to M. Tompsett from comment #2) Do you think I should not have merged FAM and FA ?
I have no issue with the merge. It seemed you lost data the 'j' when you did, and wanted to confirm that you really intended to change data when merging (i.e. FA values used over pre-existing FAM ones). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #11)
I have no issue with the merge. It seemed you lost data the 'j' when you did,
-- and I should point out that I have no knowledge of UNIMARC. I was just trying to make sense of where data was coming from and where it went when comparing the old and new. For example, if the new version of UNIMARC says no 'j', but the old had one, that's great then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to M. Tompsett from comment #11)
(In reply to Fridolin SOMERS from comment #3)
(In reply to M. Tompsett from comment #2) Do you think I should not have merged FAM and FA ?
I have no issue with the merge. It seemed you lost data the 'j' when you did, and wanted to confirm that you really intended to change data when merging (i.e. FA values used over pre-existing FAM ones).
Yep that was a mistake. Thanks for testing. I've ask my collegues to read the comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Fridolin SOMERS from comment #13)
Thanks for testing. I've ask my collegues to read the comments.
Tested the revised patch. This is purely the removal of: AUTTIT, SAUT, SCO and STU. This still has some constraint errors. Awaiting a follow-up for further testing. :) use kohadata; delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; source installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql; -- Once you get "two" patches which handle the constraint issues and contain what you believe is correct. Could you add a third which turns all the single inserts into a multi-value insert, at least for the blocks (eg. FA, whatever else...)? Thanks for the efforts. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to M. Tompsett from comment #14)
-- Once you get "two" patches which handle the constraint issues and contain what you believe is correct. Could you add a third which turns all the single inserts into a multi-value insert, at least for the blocks (eg. FA, whatever else...)? Thanks for the efforts. :)
You mean : INSERT INTO table (c1, c2, c3) VALUES (1, 'bla', 0), (2, 'bla', 1); Does it make a performance difference ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Fridolin SOMERS from comment #15)
Does it make a performance difference ?
No, but it makes a vertical scroll difference when manually testing. Also, it helps keep everything the same. If a new field is introduced, it will force an update to keep consistency, rather than have some with no value and others with a value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I have rebased after Bug 16554 was integrated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797
Fridolin SOMERS <fridolin.somers@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #52780|0 |1
is obsolete| |
--- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
Created attachment 56505
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56505&action=edit
Bug 16797 - errors in UNIMARC complet sample authorities
The SQL UNIMARC complet sample authorities fails :
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql
Some lines of auth_subfield_structure use an authtypecode not existing in lines
of authtypecode : AUTTIT, SAUT, SCO and STU.
Test plan :
- On a UNIMARC database :
- clear auth tables :
mysql> delete from auth_subfield_structure;
mysql> delete from auth_tag_structure;
mysql> delete from auth_types;
- import sql file :
mysql <
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql
=> Without patch you get error :
ERROR 1452 (23000) at line 1132: Cannot add or update a child row: a foreign
key constraint fails (`koha`.`auth_subfield_structure`, CONSTRAINT
`auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES
`auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE CASCADE)
=> With patch no errors :
> select distinct(authtypecode) from auth_subfield_structure;
+--------------+
| authtypecode |
+--------------+
| |
| CO |
| CO_UNI_TI |
| FAM |
| GENRE/FORM |
| NAME_COL |
| NP |
| PA |
| SAUTTIT |
| SNC |
| SNG |
| TM |
| TU |
+--------------+
13 rows in set (0.00 sec)
- Have a look at authoritie frameworks in Admin
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Bug 16797 depends on bug 16554, which changed state. Bug 16554 Summary: Web installer fails to load i18n sample data on MySQL 5.6+ https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #19 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #20 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 65315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65315&action=edit Bug 16797 - errors in UNIMARC complet sample authorities The SQL UNIMARC complet sample authorities fails : installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql Some lines of auth_subfield_structure use an authtypecode not existing in lines of authtypecode : AUTTIT, SAUT, SCO and STU. Test plan : - On a UNIMARC database : - clear auth tables : mysql> delete from auth_subfield_structure; mysql> delete from auth_tag_structure; mysql> delete from auth_types; - import sql file : mysql < installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql => Without patch you get error : ERROR 1452 (23000) at line 1132: Cannot add or update a child row: a foreign key constraint fails (`koha`.`auth_subfield_structure`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE CASCADE) => With patch no errors : > select distinct(authtypecode) from auth_subfield_structure; +--------------+ | authtypecode | +--------------+ | | | CO | | CO_UNI_TI | | FAM | | GENRE/FORM | | NAME_COL | | NP | | PA | | SAUTTIT | | SNC | | SNG | | TM | | TU | +--------------+ 13 rows in set (0.00 sec) - Have a look at authoritie frameworks in Admin Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #21 from Laurence Rault <laurence.rault@biblibre.com> --- tested OK with the patch but seemed OK as well without : no sql error without the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Maybe a silly question but why do not you create the authtypecodez AUTTIT, SAUT, SCO and STU instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |julian.maurice@biblibre.com --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #22)
Maybe a silly question but why do not you create the authtypecodez AUTTIT, SAUT, SCO and STU instead?
Changing status to In Discussion to have an answer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #22)
Maybe a silly question but why do not you create the authtypecodez AUTTIT, SAUT, SCO and STU instead?
I bet those codes are obsolete. Those sample files must provide a small set of frameworks to start with. One can always create more specific frameworks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #24)
(In reply to Jonathan Druart from comment #22)
Maybe a silly question but why do not you create the authtypecodez AUTTIT, SAUT, SCO and STU instead?
I bet those codes are obsolete. Those sample files must provide a small set of frameworks to start with. One can always create more specific frameworks.
"I bet" is not convincing enough ;) I had the same question when glancing thru your patch. Please explain. When were these codes added, removed, etc. Did they forget to remove these lines ? Please do some git research to provide further evidence. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18309 CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this has been resolved since, the .yml files for the UNIMARC installer no longer contain the removed authtypecodes. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org