https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14598 Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57397&action=edit Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings This patch makes t/db_dependent/Patron/Borrower_Discharge.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Patron/Borrower_Discharge.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #2)

No errors for me without patch (master commit 80c80ca683217455221e15e0c24a81d5e60e49e0)

t/db_dependent/Patron/Borrower_Discharge.t .. ok All tests successful. Files=1, Tests=18, 3 wallclock secs ( 0.02 usr 0.00 sys + 1.89 cusr 0.11 csys = 2.02 CPU) Result: PASS

Don't you get warnings? This is what I get: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_Discharge.t .. item-level_itypes set but no itemtype set for item (1291) at /home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 698. t/db_dependent/Patron/Borrower_Discharge.t .. 1/18 item-level_itypes set but no itemtype set for item (1291) at /home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 698. t/db_dependent/Patron/Borrower_Discharge.t .. ok All tests successful. Files=1, Tests=18, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.72 cusr 0.26 csys = 2.01 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57441&action=edit Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings This patch makes t/db_dependent/Patron/Borrower_Discharge.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Patron/Borrower_Discharge.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57434|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17603 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.