https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57349&action=edit Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57349|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57368&action=edit [SIGNED-OFF] Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57368|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57444&action=edit Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.