https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 203225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203225&action=edit Bug 43239: Preserve item item type if previousitemtype column is undefined It is possible to create serial item with wrong itemtype if syspreference makePreviousSerialAvailable is enabled and field "item type for older issues" isn't filled when creating a subscription for biblio record. This happens when multiple items are created. In installations where itemtypes differ between items and biblios, this causes data inconsistencies and leads to errors in biblios Holdings table. This patch changes behaviour of serials-edit.pl so that if makePreviousSerialAvailable is enabled and subscriptions previousitemtype column is NULL, previous serial items itype column is preserved. It also adds a hint text to subscription form about this change. To test: 1. Enable systempreference makePreviousSerialAvailable. 2. Create new biblio record. 3. Create a new subscription for biblio record you made, select option "Create an item record", select different item type from "Item type" selection than biblio record has but leave selection "item type for older issues" empty. 4. Receive a serial item for subscription. Check from biblio records Holdings table that its item type matches item type selected in step 3. 5. Now receive 3 serial items. After creating them check Holdings table again. => Note that first item created now has same item type as biblio record. 6. Apply this patch, restart services. 7. Create new subscription, fill needed fields as in step 3. => Note that there is a new hint text after field "item type for older issues". 8. Repeat steps 4. and 5. => Note that now all items have same item type. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Koha-Suomi Oy list of Sponsors| | Status|Needs Signoff |Signed Off Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 203381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203381&action=edit Bug 43239: Preserve item item type if previousitemtype column is undefined It is possible to create serial item with wrong itemtype if syspreference makePreviousSerialAvailable is enabled and field "item type for older issues" isn't filled when creating a subscription for biblio record. This happens when multiple items are created. In installations where itemtypes differ between items and biblios, this causes data inconsistencies and leads to errors in biblios Holdings table. This patch changes behaviour of serials-edit.pl so that if makePreviousSerialAvailable is enabled and subscriptions previousitemtype column is NULL, previous serial items itype column is preserved. It also adds a hint text to subscription form about this change. To test: 1. Enable systempreference makePreviousSerialAvailable. 2. Create new biblio record. 3. Create a new subscription for biblio record you made, select option "Create an item record", select different item type from "Item type" selection than biblio record has but leave selection "item type for older issues" empty. 4. Receive a serial item for subscription. Check from biblio records Holdings table that its item type matches item type selected in step 3. 5. Now receive 3 serial items. After creating them check Holdings table again. => Note that first item created now has same item type as biblio record. 6. Apply this patch, restart services. 7. Create new subscription, fill needed fields as in step 3. => Note that there is a new hint text after field "item type for older issues". 8. Repeat steps 4. and 5. => Note that now all items have same item type. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the item type release notes| |created for serials, when | |item records are created | |for subscriptions. | | | |Explanation: | | | |It is possible to create | |subscription item records | |with the wrong | |item type if: | |- the | |makePreviousSerialAvailable | |system preference is | |enabled, and | |- there is no value | |selected for the "Item type | |for older issues" field. | | | |In installations where item | |types differ between items | |and records, this causes | |data inconsistencies and | |leads to errors in a | |record's holdings table. | | | |This fix changes the | |behaviour of the serials | |subscription form so that | |if | |makePreviousSerialAvailable | |is enabled and a | |subscription's "Item type | |for older issues" field is | |empty/not selected, the | |previous item type value is | |kept for item records. It | |also adds a hint text to | |the subscription form about | |this change. CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I added a follow-up for the hint: - Original: If older issues itemtype is not selected old item type is preserved. - Updated: If no value is selected, then the item type used for older issues is kept. Feel free to obsolete if I haven't got it right: 1. As a minimum, I think itemtype should be spelt as two words. 2. I don't think I have quite got it right, but I think there should be something in the hint about why you would select a value for this field/why you would use this option. 3. As someone who doesn't use Koha in real life, and serials in particular, I don't really understand why you would have different item types for items attached to a record. I think this should try to explain this somehow to help avoid any confusion. 8-) 4. Is the "Item type for older issues" field only used if the makePreviousSerialAvailablesystem preference is enabled? If so, we should probably say that. (That is, why would you use this field?) I have attempted a release note, please update if I have got it worng. Testing notes (using KTD): 1. Step 2 - When creating the record for the serial: - Framework: Serial - 942$c: Continuing Resources 2. Step 3 - When creating the subscription: - Item type: Music 3. Step 4 - Item time for the item created was "Music" 4. Step 5 - The item type for the three items received was "Continuing Resources" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203381|0 |1 is obsolete| | Attachment #203382|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 203386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203386&action=edit Bug 43239: (follow-up) Update wording for hint Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43239 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, I got a warning about the patches not being tidy in the QA tools, please check your setup: Result: [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt [FAIL] serials/serials-edit.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl serials/serials-edit.pl` I amended the first patch after I ran the tidy. I am also making a suggestion for a rephrasing of the hint on the form. I feel it's clearer to say the item type won't be changed as it could have been updated to any item type since the item was initially created. -- You are receiving this mail because: You are watching all bug changes.