[Bug 43110] New: When a patron has a value for advance notices the checkboxes are enabled on the details view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Bug ID: 43110 Summary: When a patron has a value for advance notices the checkboxes are enabled on the details view Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- To recreate: 1 - Edit a patron, set a value for advance notices, do not check any transports 2 - View the details for the patron: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 3 - Note the checkboxes are enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28308 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28308 [Bug 28308] Select 'Days in advance' = 0 for Advance notice effectively disables PREDUE notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't recreate. On main (commit 037d38b00cd): /cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=51 Set Advance notice = 17 Save On /cgi-bin/koha/members/moremember.pl?borrowernumber=51 I see: https://snipboard.io/RYV8Qa.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #1)
I don't recreate.
On main (commit 037d38b00cd): /cgi-bin/koha/members/memberentry. pl?op=edit_form&destination=circ&borrowernumber=51 Set Advance notice = 17 Save On /cgi-bin/koha/members/moremember.pl?borrowernumber=51 I see: https://snipboard.io/RYV8Qa.jpg
I see the problem in your screenshot - the 'Advance Notice' checkboxes are not disabled, you can check and uncheck them - it doesn't affect the values, but is not right https://snipboard.io/F62zT4.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202224&action=edit Bug 43110: (bug 28308 follow-up) Disable checkboxes on the detail view Checkboxes must be disabled on the detail page as we cannot submit the changes. Test plan: 1 - Edit a patron, set a value for advance notices, do not check any transports 2 - View the details for the patron: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 3 - Note the checkboxes are disabled QA: The logic is a bit weird as messaging_form_inactive is not set if the pref is off, but the table is not displayed in this case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens (kidclamp) from comment #2)
I see the problem in your screenshot - the 'Advance Notice' checkboxes are not disabled, you can check and uncheck them - it doesn't affect the values, but is not right
Yes, sorry. I misread "enabled" vs "disabled". Should be fixed now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 202249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202249&action=edit Bug 43110: (bug 28308 follow-up) Disable checkboxes on the detail view Checkboxes must be disabled on the detail page as we cannot submit the changes. Test plan: 1 - Edit a patron, set a value for advance notices, do not check any transports 2 - View the details for the patron: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 3 - Note the checkboxes are disabled QA: The logic is a bit weird as messaging_form_inactive is not set if the pref is off, but the table is not displayed in this case. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Trivial, PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43110 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #9 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- *** Bug 42814 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org