[Bug 42814] New: Advance notice checkboxes enabled in inactive messaging preferences form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 Bug ID: 42814 Summary: Advance notice checkboxes enabled in inactive messaging preferences form Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- Bug 28308 added JavaScript to disable the Advance notice transport checkboxes when "Days in advance" is blank. However, the JavaScript only checks the value of the days select. When the messaging preferences form is inactive/read-only and a non-blank days value is selected, the script removes the disabled state from the checkboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 200190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200190&action=edit Bug 42814: Respect inactive messaging preferences form in advance notice JS To test: 1. Set a patron's Advance notice "Days in advance" value to a non-blank value such as 1 or 2. 2. Save the patron. 3. View the patron messaging preferences without entering edit mode. => Notice that the Advance notice checkboxes remain enabled and can be selected. => Selecting them does not actually make any changes to the messaging preferences. 4. Set "Days in advance" to blank and save. => Notice that the Advance notice checkboxes are disabled when not in edit mode. 5. Apply the patch. 6. Repeat steps 1-2. 7. View the patron messaging preferences without entering edit mode. => Confirm that the Advance notice checkboxes remain disabled. 8. Enter edit mode. => Confirm that the Advance notice checkboxes can still be edited. 9. Set "Days in advance" to blank. => Confirm that the Advance notice checkboxes are disabled. 10. Confirm that messaging preferences can still be saved successfully. 11. Sign off and have a spectacular day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 200221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200221&action=edit Bug 42814: Respect inactive messaging preferences form in advance notice JS To test: 1. Set a patron's Advance notice "Days in advance" value to a non-blank value such as 1 or 2. 2. Save the patron. 3. View the patron messaging preferences without entering edit mode. => Notice that the Advance notice checkboxes remain enabled and can be selected. => Selecting them does not actually make any changes to the messaging preferences. 4. Set "Days in advance" to blank and save. => Notice that the Advance notice checkboxes are disabled when not in edit mode. 5. Apply the patch. 6. Repeat steps 1-2. 7. View the patron messaging preferences without entering edit mode. => Confirm that the Advance notice checkboxes remain disabled. 8. Enter edit mode. => Confirm that the Advance notice checkboxes can still be edited. 9. Set "Days in advance" to blank. => Confirm that the Advance notice checkboxes are disabled. 10. Confirm that messaging preferences can still be saved successfully. 11. Sign off and have a spectacular day! Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 --- Comment #3 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Thanks for this easy-to-follow testing plan. I went through the steps in a sandbox and things looked good. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42814 Daniel B. <dbarden@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dbarden@cuyahogalibrary.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org