[Bug 27949] New: Batch printing of article request slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Bug ID: 27949 Summary: Batch printing of article request slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We propose allowing for staff to select multiple article requests on the screen and have Koha generate them and print in one transaction through the browser. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 121608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121608&action=edit Bug 27949: Allow multiple article requests print slip This bug allows for batch printing of multiple article requests slips To test: 1. apply this patch 2. restart_all 3. enable ArticleRequests preference 4. create multiple article requests 5. go to circ/article-requests.pl in staff interface 6. print a single slip from a row CHECK => it works as expected 7. select all rows and print slip from general actions menu (above the table) SUCCESS => all article requests slips are printed 8. select multiple rows (not all) and print slip from general actions menu (above the table) SUCCESS => only selected article requests slips are printed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I was on the edge of testing this until someone deciced to add a second perllib and my setup no longer works, aarggg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What if I would like to have these notices on a separate page? I would be inclined to look for a solution with NoticeCSS and a page-break-after. Should this development respect NoticeCSS ? Please have a look at: Koha/Patron/Discharge.pm, sub generate_as_pdf misc/cronjobs/gather_print_notices.pl, sub generate_html Both are using: koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #4 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Marcel, sorry for the delay. For what I've seen, printslip.tt uses SlipCSS stylesheet (if defined) where you may say, for example hr { display: none; page-break-after: always; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Agustín Moyano from comment #4)
Hi Marcel, sorry for the delay. For what I've seen, printslip.tt uses SlipCSS stylesheet (if defined) where you may say, for example
hr { display: none; page-break-after: always; }
Did you test this yourself? I already did some testing with page-break-after but couldnt get it to work. I now inserted the exact lines above in a stylesheet for SlipCSS but it does not work either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The issue raised on comment3 (tomorrow exactly three months ago) is imo legitimate, but has not been answered sufficiently. Changing status to emphasize the need for feedback in all appreciation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #7 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Marcel de Rooy from comment #5)
(In reply to Agustín Moyano from comment #4)
Hi Marcel, sorry for the delay. For what I've seen, printslip.tt uses SlipCSS stylesheet (if defined) where you may say, for example
hr { display: none; page-break-after: always; }
Did you test this yourself?
I already did some testing with page-break-after but couldnt get it to work. I now inserted the exact lines above in a stylesheet for SlipCSS but it does not work either.
Hi Marcel, I did not test it, but my point was that printslip.tt includes a css, just as print-notices.tt where you can define page breaking conditions. Let me play around a bit, and I'll post a working example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Marcel, the following code worked for me hr { page-break-after: always; border: 0px solid black !important; } First times did not work, but I believe it was browser's cache or memcached Could you try again, please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Agustín Moyano from comment #8)
Hi Marcel, the following code worked for me
hr { page-break-after: always; border: 0px solid black !important; }
First times did not work, but I believe it was browser's cache or memcached
Could you try again, please?
It works for me now. Not sure what changed. Anyway, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121608|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125183&action=edit Bug 27949: Allow multiple article requests print slip This bug allows for batch printing of multiple article requests slips To test: 1. apply this patch 2. restart_all 3. enable ArticleRequests preference 4. create multiple article requests 5. go to circ/article-requests.pl in staff interface 6. print a single slip from a row CHECK => it works as expected 7. select all rows and print slip from general actions menu (above the table) SUCCESS => all article requests slips are printed 8. select multiple rows (not all) and print slip from general actions menu (above the table) SUCCESS => only selected article requests slips are printed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply Depends on| |29086 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Adding a dependency to organize things. It doesn't apply. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 [Bug 29086] Reuse article request filtering methods in Biblio template plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125183|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125248&action=edit Bug 27949: Allow multiple article requests print slip This bug allows for batch printing of multiple article requests slips To test: 1. apply this patch 2. restart_all 3. enable ArticleRequests preference 4. create multiple article requests 5. go to circ/article-requests.pl in staff interface 6. print a single slip from a row CHECK => it works as expected 7. select all rows and print slip from general actions menu (above the table) SUCCESS => all article requests slips are printed 8. select multiple rows (not all) and print slip from general actions menu (above the table) SUCCESS => only selected article requests slips are printed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 [Bug 29110] Refactor Koha::ArticleRequest->store -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125248|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125882&action=edit Bug 27949: Allow multiple article requests print slip This bug allows for batch printing of multiple article requests slips To test: 1. apply this patch 2. restart_all 3. enable ArticleRequests preference 4. create multiple article requests 5. go to circ/article-requests.pl in staff interface 6. print a single slip from a row CHECK => it works as expected 7. select all rows and print slip from general actions menu (above the table) SUCCESS => all article requests slips are printed 8. select multiple rows (not all) and print slip from general actions menu (above the table) SUCCESS => only selected article requests slips are printed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125883&action=edit Bug 27949: (QA follow-up) Remove TODO Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Bug 27949 depends on bug 29086, which changed state. Bug 29086 Summary: Reuse article request filtering methods in Biblio template plugin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- + $slipContent .= "<hr/>"; + $slipContent .= $slip->{is_html}?$slip->{content}:'<pre>'.$slip->{content}.'</pre>'; This is arbitrary, not configurable, and add html code in controller. That smells. I don't have a good suggestion right now however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125882|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126263&action=edit Bug 27949: Allow multiple article requests print slip This bug allows for batch printing of multiple article requests slips To test: 1. apply this patch 2. restart_all 3. enable ArticleRequests preference 4. create multiple article requests 5. go to circ/article-requests.pl in staff interface 6. print a single slip from a row CHECK => it works as expected 7. select all rows and print slip from general actions menu (above the table) SUCCESS => all article requests slips are printed 8. select multiple rows (not all) and print slip from general actions menu (above the table) SUCCESS => only selected article requests slips are printed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> JD amended patch: Perltidy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126263|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126264&action=edit Bug 27949: Allow multiple article requests print slip This bug allows for batch printing of multiple article requests slips To test: 1. apply this patch 2. restart_all 3. enable ArticleRequests preference 4. create multiple article requests 5. go to circ/article-requests.pl in staff interface 6. print a single slip from a row CHECK => it works as expected 7. select all rows and print slip from general actions menu (above the table) SUCCESS => all article requests slips are printed 8. select multiple rows (not all) and print slip from general actions menu (above the table) SUCCESS => only selected article requests slips are printed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> JD amended patch: Perltidy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125883|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126265&action=edit Bug 27949: (QA follow-up) Remove TODO Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #15)
+ $slipContent .= "<hr/>";
+ $slipContent .= $slip->{is_html}?$slip->{content}:'<pre>'.$slip->{content}.'</pre>';
This is arbitrary, not configurable, and add html code in controller. That smells.
I don't have a good suggestion right now however.
Do we open a follow-up bug report for that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #20)
(In reply to Jonathan Druart from comment #15)
+ $slipContent .= "<hr/>";
+ $slipContent .= $slip->{is_html}?$slip->{content}:'<pre>'.$slip->{content}.'</pre>';
This is arbitrary, not configurable, and add html code in controller. That smells.
I don't have a good suggestion right now however.
Do we open a follow-up bug report for that?
How about the title of bug 29262 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29262 [Bug 29262] Remove tinkering with html from circ/article-request-slip.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This developments adds a release notes| |way to select several | |article requests and print | |slips for them in batch. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22590 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org