[Bug 16233] New: Unclosed <strong> tag in the opac-facets.inc breaks some display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 Bug ID: 16233 Summary: Unclosed <strong> tag in the opac-facets.inc breaks some display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org There are 2 <strong> tags in the availability section of opac-facets.inc So if you restrict by availability you get some odd display issues on the search results screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 50099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50099&action=edit Bug 16233 Unclosed <strong> in opac-facets.inc To test: 1/ Do a search in the OPAC 2/ Restrict to only available items 3/ Notice the authors now appear bold 4/ Apply patch 5/ Refresh the page 6/ Authors should now look normal again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 50099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50099 Bug 16233 Unclosed <strong> in opac-facets.inc Review of attachment 50099: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16233&attachment=50099) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc @@ -6,4 @@
<ul> <li> [% IF ( available ) %] - <strong>Showing only available items<strong></li><li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]">Show all items</a>
Good catch! Just a single / missing to close the tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50099|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 50107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50107&action=edit Bug 16233 Unclosed <strong> in opac-facets.inc To test: 1/ Do a search in the OPAC 2/ Restrict to only available items 3/ Notice the authors now appear bold 4/ Apply patch 5/ Refresh the page 6/ Authors should now look normal again Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50107|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50110&action=edit [PASSED QA] Bug 16233 Unclosed <strong> in opac-facets.inc To test: 1/ Do a search in the OPAC 2/ Restrict to only available items 3/ Notice the authors now appear bold 4/ Apply patch 5/ Refresh the page 6/ Authors should now look normal again Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16233 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org