https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 50541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50541&action=edit Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable This patch adds translatability for the tab "Unknown" in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt To test: - Apply patch - Examine koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt and verify that it handles the label "Unknown" (line 496) - Go to suggestion/suggestion.pl, set status of a suggestion to -- Choose a status -- and verify that the tab "Status unknown" appears - Bonus test: Go through a translation process and verify that "Status unknown" is translated Note: If you have a suggestion with unknown status, all suggestions are listed under this tab. This is not in the scope of this bug; this bug is about translation only. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50541|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 50543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50543&action=edit Bug 16322 Translatability: "Unknown" in suggestion/suggestion.pl not translatable This patch adds translatability for the tab "Unknown" in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt To test: - Apply patch - Examine koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt and verify that it handles the label "Unknown" (line 496) - Go to suggestion/suggestion.pl, set status of a suggestion to -- Choose a status -- and verify that the tab "Status unknown" appears - Bonus test: Go through a translation process and verify that "Status unknown" is translated Note: If you have a suggestion with unknown status, all suggestions are listed under this tab. This is not in the scope of this bug; this bug is about translation only. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Marc I changed the status unknown in the column table too. Feel free to obsolete the last patch if you don't like the idea. No Biggie. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50544|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 50560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50560&action=edit Bug 16322: Translatability: Also adding "Status unknown" to column table Also add the "Status unknown to the column table To test: follow previous commit Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 [Bug 16325] Suggestions: Tab "Status unknown" contains all suggestions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 50575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50575&action=edit Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable This patch adds translatability for the tab "Unknown" in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt To test: - Apply patch - Examine koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt and verify that it handles the label "Unknown" (line 496) - Go to suggestion/suggestion.pl, set status of a suggestion to -- Choose a status -- and verify that the tab "Status unknown" appears - Bonus test: Go through a translation process and verify that "Status unknown" is translated Note: If you have a suggestion with unknown status, all suggestions are listed under this tab. This is not in the scope of this bug; this bug is about translation only. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Attachment #50543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.