[Bug 27884] New: Add html mail support for email report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Bug ID: 27884 Summary: Add html mail support for email report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org In bug 16149 patron_emailer.pl was added so reports can send mail to users. This mail is administered in the same way as other notice-templates (tools, notices and slips). When creating mail templates there is an option for plaintext or html mail. This setting is not respected for emails handled by patron_emailer.pl which this patch should fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 117869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117869&action=edit Bug 123123: Add html support for report mails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #2 from Michal Denar <black23@gmail.com> --- Hi David,any test plan? Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117869|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Created attachment 117942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117942&action=edit Bug 123123: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons" and name/code TEST 2) Create a new sql report, the query could be someting like: SELECT "<number>" as `borrowernumber`, "to@example.com", as `email`, "from@example.com" as `from`; where "<number>" is a valid borrowernumber. 3) Run patron_emailer.pl --report=<id> --notice=TEST --module=members -commit where <id> is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117942|0 |1 is obsolete| | --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- Created attachment 117943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117943&action=edit Bug 123123: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "<strong>testing<strong>". 2) Create a new sql report, the query could be someting like: SELECT "<number>" as `borrowernumber`, "to@example.com", as `email`, "from@example.com" as `from`; where "<number>" is a valid borrowernumber. 3) Run patron_emailer.pl --report=<id> --notice=TEST --module=members -commit where <id> is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117943|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #5 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118929&action=edit Bug 123123: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "<strong>testing<strong>". 2) Create a new sql report, the query could be someting like: SELECT "<number>" as `borrowernumber`, "to@example.com", as `email`, "from@example.com" as `from`; where "<number>" is a valid borrowernumber. 3) Run patron_emailer.pl --report=<id> --notice=TEST --module=members -commit where <id> is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi Status|Signed Off |Failed QA --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Looks good but an automated test is still needed for this in t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 --- Comment #7 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- The bug number was also not right in the patch title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118929|0 |1 is obsolete| | --- Comment #8 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124890&action=edit Bug 27884: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "<strong>testing<strong>". 2) Create a new sql report, the query could be someting like: SELECT "<number>" as `borrowernumber`, "to@example.com", as `email`, "from@example.com" as `from`; where "<number>" is a valid borrowernumber. 3) Run patron_emailer.pl --report=<id> --notice=TEST --module=members -commit where <id> is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. 6) Run tests in t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124891&action=edit Bug 27884: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124890|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 125755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125755&action=edit Bug 27884: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "<strong>testing<strong>". 2) Create a new sql report, the query could be someting like: SELECT "<number>" as `borrowernumber`, "to@example.com", as `email`, "from@example.com" as `from`; where "<number>" is a valid borrowernumber. 3) Run patron_emailer.pl --report=<id> --notice=TEST --module=members -commit where <id> is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. 6) Run tests in t/db_dependent/Reports/Guided.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124891|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 125756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125756&action=edit Bug 27884: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125755|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127184&action=edit Bug 27884: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "<strong>testing<strong>". 2) Create a new sql report, the query could be someting like: SELECT "<number>" as `borrowernumber`, "to@example.com", as `email`, "from@example.com" as `from`; where "<number>" is a valid borrowernumber. 3) Run patron_emailer.pl --report=<id> --notice=TEST --module=members -commit where <id> is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. 6) Run tests in t/db_dependent/Reports/Guided.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125756|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127185&action=edit Bug 27884: Add tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix covered by tests.. works well.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add html mail support for |Add HTML mail support for |email report |patron emailer script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org