https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 --- Comment #1 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 104711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104711&action=edit Bug 25459: Makes barcode position respect units in patron cards layout When using any unit besides postscript points, barcode positionning doesn't work correctly. There is an error in the calculation: the unit factor must be applied to the individual card part only and not to the full page position. This patch moves the unit part of the calculation to the right place. To test : 1. Create a working patron card setup, using postscript points: card template, layout and card batch. Use barcode and at least one other element (text or images) in the layout. => Some tips for testing: - activate guides for the layout - use a template and a batch containing more than one card; the displacement will be different for each card and depend on the barcode position relative to the bottom left of the entire page. 2. Change units from postscript points to any other unit. => At least for the layout, but changing it in the template will scale the page as well. 4. Export the card batch. 3. Note the guides are scaled to fit the new unit and the lower left corner of text and images are still correctly placed relative to the guides, but the barcode is not. => In some cases, the barcode even seem to not print at all since it's new coordinates are out of screen. 4. Apply patch. 5. Generate the batch again. 6. Note the barcode now appears exactly where it should. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126474|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127186&action=edit Bug 25459: Makes barcode position respect units in patron cards layout When using any unit besides postscript points, barcode positionning doesn't work correctly. There is an error in the calculation: the unit factor must be applied to the individual card part only and not to the full page position. This patch moves the unit part of the calculation to the right place. To test : 1. Create a working patron card setup, using postscript points: card template, layout and card batch. Use barcode and at least one other element (text or images) in the layout. => Some tips for testing: - activate guides for the layout - use a template and a batch containing more than one card; the displacement will be different for each card and depend on the barcode position relative to the bottom left of the entire page. 2. Change units from postscript points to any other unit. => At least for the layout, but changing it in the template will scale the page as well. 4. Export the card batch. 3. Note the guides are scaled to fit the new unit and the lower left corner of text and images are still correctly placed relative to the guides, but the barcode is not. => In some cases, the barcode even seem to not print at all since it's new coordinates are out of screen. 4. Apply patch. 5. Generate the batch again. 6. Note the barcode now appears exactly where it should. Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.