[Bug 42564] New: Upgrade Font Awesome in the staff interface to 7.2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Bug ID: 42564 Summary: Upgrade Font Awesome in the staff interface to 7.2 Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 34973 Building on Bug 34973, we should upgrade Font Awesome in the staff interface to 7.2. Besides helping to keep assets up to date this fixes the constant "downloadable font: Glyph bbox was incorrect" warnings in the browser console. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 [Bug 34973] Update Font Awesome to fix JS warning in the console for Firefox: "Glyph bbox was incorrect" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198835&action=edit Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 We are using Font Awesome 6.3 in the staff interface. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch updates the staff interface CSS so that it pulls Font Awesome CSS from node_modules. Font assets have been updated in lib/fontawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the staff interface SCSS. - Clear your browser cache. - Test many pages in the staff interface to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: The h1 heading "Koha home" on the staff interface main page, the <legend> tag on the new currency form in Administration -> Currencies and exchange rates. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198842&action=edit Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 We are using Font Awesome 6.3 in the staff interface. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch updates the staff interface CSS so that it pulls Font Awesome CSS from node_modules. Font assets have been updated in lib/fontawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the staff interface SCSS. - Clear your browser cache. - Test many pages in the staff interface to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: The h1 heading "Koha home" on the staff interface main page, the <legend> tag on the new currency form in Administration -> Currencies and exchange rates. Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 199885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199885&action=edit Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 We are using Font Awesome 6.3 in the staff interface. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch updates the staff interface CSS so that it pulls Font Awesome CSS from node_modules. Font assets have been updated in lib/fontawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the staff interface SCSS. - Clear your browser cache. - Test many pages in the staff interface to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: The h1 heading "Koha home" on the staff interface main page, the <legend> tag on the new currency form in Administration -> Currencies and exchange rates. Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This upgrades the version release notes| |of Font Awesome used for | |the staff interface from | |6.2 to 7.2. | | | |This also fixes numerous | |browser console JavaScript | |errors in the browser | |console ("downloadable | |font: Glyph bbox was | |incorrect" warnings) about | |Font Awesome for the staff | |interface when using | |Firefox. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I've added my sign-off in case Laura's sign-off can count as QA. Notes: 1. After the patch, a git grep "sr-only" now only shows these occurrences in the code: koha-tmpl/opac-tmpl/bootstrap/css/bootstrap-theme-oai.css:.sr-only { koha-tmpl/opac-tmpl/bootstrap/css/bootstrap-theme-oai.css:.sr-only-focusable:active, koha-tmpl/opac-tmpl/bootstrap/css/bootstrap-theme-oai.css:.sr-only-focusable:focus { koha-tmpl/opac-tmpl/bootstrap/css/bootstrap-theme-oai.css:.has-feedback label.sr-only ~ .form-control-feedback { 2. Running the qa script, there are several warnings about files not found for some template files File not found : lib/fontawesome/css/fontawesome.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. File not found : lib/fontawesome/css/brands.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. File not found : lib/fontawesome/css/solid.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. File not found : lib/fontawesome/css/fontawesome.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. File not found : lib/fontawesome/css/brands.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199885|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199898&action=edit Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 We are using Font Awesome 6.3 in the staff interface. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch updates the staff interface CSS so that it pulls Font Awesome CSS from node_modules. Font assets have been updated in lib/fontawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the staff interface SCSS. - Clear your browser cache. - Test many pages in the staff interface to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: The h1 heading "Koha home" on the staff interface main page, the <legend> tag on the new currency form in Administration -> Currencies and exchange rates. Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199899&action=edit Bug 42564: (follow-up) Actually remove calls to old assets Also incorporate the Font Awesome assets into the installer SCSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Thank you for the detailed testing notes David, that allowed me to correct a dumb mistake! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42771 [Bug 42771] Change icon used in installer to represent unfinished steps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Bug 42564 depends on bug 34973, which changed state. Bug 34973 Summary: Update Font Awesome for the OPAC to fix JavaScript warning in the console for Firefox: "Glyph bbox was incorrect" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199898|0 |1 is obsolete| | Attachment #199899|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200478&action=edit Bug 42564: Upgrade Font Awesome in the staff interface to 7.2 We are using Font Awesome 6.3 in the staff interface. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch updates the staff interface CSS so that it pulls Font Awesome CSS from node_modules. Font assets have been updated in lib/fontawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the staff interface SCSS. - Clear your browser cache. - Test many pages in the staff interface to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: The h1 heading "Koha home" on the staff interface main page, the <legend> tag on the new currency form in Administration -> Currencies and exchange rates. Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200479&action=edit Bug 42564: (follow-up) Actually remove calls to old assets Also incorporate the Font Awesome assets into the installer SCSS. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200845&action=edit Bug 42564: Fix Template/Plugin/Asset.t lib/fontawesome/css/fontawesome.min.css was used as an example for this test, let's use datatables.min.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Keywords|additional_work_needed | --- Comment #12 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #11)
Created attachment 200845 [details] [review] Bug 42564: Fix Template/Plugin/Asset.t
lib/fontawesome/css/fontawesome.min.css was used as an example for this test, let's use datatables.min.css
Follow-up pushed. Thanks Joubu! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement will not be backported to 26.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org