[Bug 32942] New: Suggestion API is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Bug ID: 32942 Summary: Suggestion API is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com CC: tomascohen@gmail.com To reproduce, create a couple of suggestion and set them to status either blank or "ORDERED". Query the api to fetch all the suggestions : https://[your koha]/api/v1/suggestions If any of the suggestion you would like to get with a query has no status, or not within fixed list of values, you would get this error message : <pre> {"errors":[{"message":"Not in enum list: ASKED, CHECKED, ACCEPTED, REJECTED.","path":"\/1\/status"}],"status":200} </pre> A suggestion may also have status "ORDERED" which is not in the list, or no status at all. API should not throw this error on status and give the other details for the suggestion instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27183 [Bug 27183] Make suggestions management use the API -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Also status "AVAILABLE" breaks things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can you provide regression tests? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- I confirm the issue. You can have additional values for suggestions.STATUS field coming from SUGGEST_STATUS authorised_values list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- It's here: https://git.koha-community.org/Koha-community/Koha/src/branch/master/api/v1/... I suppose this part should be shaved: enum: - ASKED - CHECKED - ACCEPTED - REJECTED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 146508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146508&action=edit Bug 32942: Suggestion API route when non 'standard' status are present The API route for listing all suggestion: /api/v1/suggestions send back an error message when there is a suugestion with non standard status (ASKED, CHECKED, ACCEPTED, REJECTED). This patch fixes this too restrictive restriction. TO TEST: 1. Add a status in SUGGEST_STATUS AV list. 2. Create a suggestion, and assign it to the previsous status. 3. Call /api/v1/suggestion 3. You get an error message: { "errors": [ { "message":"Not in enum list: ASKED, CHECKED, ACCEPTED, REJECTED.", "path":"\/1\/status" }], "status":200 } 4. Apply the patch. Call /api/v1/suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs@lists.koha-commun |frederic@tamil.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestion API is broken |Suggestion API doesn't | |support custom statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 146592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146592&action=edit Bug 32942: Regression tests Having a custom status shouldn't cause issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 146593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146593&action=edit Bug 32942: Suggestion API route when non 'standard' status are present The API route for listing all suggestion: /api/v1/suggestions send back an error message when there is a suugestion with non standard status (ASKED, CHECKED, ACCEPTED, REJECTED). This patch fixes this too restrictive restriction. TO TEST: 1. Add a status in SUGGEST_STATUS AV list. 2. Create a suggestion, and assign it to the previsous status. 3. Call /api/v1/suggestion 3. You get an error message: { "errors": [ { "message":"Not in enum list: ASKED, CHECKED, ACCEPTED, REJECTED.", "path":"\/1\/status" }], "status":200 } 4. Apply the patch. Call /api/v1/suggestion Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 146594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146594&action=edit Bug 32942: (QA follow-up) Document possible values Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- If the spec is no longer doing the check, shouldn't the controller have a test about it? It's not an enum for the rest api specs because we cannot list the values there, but it's still a list of possible values. Other values must be rejected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Jonathan Druart from comment #9)
If the spec is no longer doing the check, shouldn't the controller have a test about it? It's not an enum for the rest api specs because we cannot list the values there, but it's still a list of possible values. Other values must be rejected.
Couldn't we just set status to "ASKED" or "UNKNOWN" for any value other than the one defined in the authorized_value? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 154642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154642&action=edit Bug 32942: (QA follow-up) Add tests for STATUS checking in Suggestion::store -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 154643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154643&action=edit Bug 32942: (QA follow-up) Moving Suggestion->STATUS check to Suggestion::store -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146592|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155801&action=edit Bug 32942: Regression tests Having a custom status shouldn't cause issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146593|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155802&action=edit Bug 32942: Suggestion API route when non 'standard' status are present The API route for listing all suggestion: /api/v1/suggestions send back an error message when there is a suugestion with non standard status (ASKED, CHECKED, ACCEPTED, REJECTED). This patch fixes this too restrictive restriction. TO TEST: 1. Add a status in SUGGEST_STATUS AV list. 2. Create a suggestion, and assign it to the previsous status. 3. Call /api/v1/suggestion 3. You get an error message: { "errors": [ { "message":"Not in enum list: ASKED, CHECKED, ACCEPTED, REJECTED.", "path":"\/1\/status" }], "status":200 } 4. Apply the patch. Call /api/v1/suggestion Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146594|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155803&action=edit Bug 32942: (QA follow-up) Document possible values Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154642|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155804&action=edit Bug 32942: (QA follow-up) Add tests for STATUS checking in Suggestion::store Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154643|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155805&action=edit Bug 32942: (QA follow-up) Moving Suggestion->STATUS check to Suggestion::store Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155806&action=edit Bug 32942: (QA follow-up) Fix regression test With the move to checking status during store, we broke the api regression test introduced earlier in the patch set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Fix QA script issues inline and added a final follow-up to fix the failing regression test we broke with the migration to checking in store. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hi, There is a typo in changes by "(QA follow-up) Document possible values" : + * Values from the `SUGGEST_STATUS` av cateogry cateogry => category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Also this: kohadev-koha@kohadevbox:koha(master)$ prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. 1/91 # Failed test 'ModSuggestion status warning is correct' # at t/db_dependent/Suggestions.t line 213. # didn't find a warning # expected to find warning: No suggestions STALLED letter transported by email # Failed test 'ModSuggestion Status OK' # at t/db_dependent/Suggestions.t line 215. # got: '0' # expected: '1' t/db_dependent/Suggestions.t .. 88/91 # Looks like you failed 2 tests of 91. -- You are receiving this mail because: You are watching all bug changes.
git grep 'ASKED.*REJECTED' origin/master origin/master:Koha/Schema/Result/Suggestion.pm:suggestion status (ASKED, CHECKED, ACCEPTED, REJECTED, ORDERED, AVAILABLE or a value from the SUGGEST_STATUS authorised value category) origin/master:Koha/Suggestion.pm: my @status_constants = qw(ASKED CHECKED ACCEPTED REJECTED); origin/master:installer/data/mysql/kohastructure.sql: `STATUS` varchar(10) NOT NULL DEFAULT '' COMMENT 'suggestion status (ASKED, CHECKED, ACCEPTED, REJECTED, ORDERED, AVAILABLE or a value from the SUGGEST_STATUS authorised value category)', origin/master:misc/cronjobs/archive_purchase_suggestions.pl: push @available_statuses, qw( ASKED ACCEPTED CHECKED REJECTED ORDERED AVAILABLE ); origin/master:misc/cronjobs/archive_purchase_suggestions.pl:It must be one of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh and I see that ORDERED and AVAILABLE are missing from my @status_constants no ? the 6 default statuses (ASKED, ACCEPTED, CHECKED, REJECTED, ORDERED or AVAILABLE), or one define in the SUGGEST_STATUS authorized value's category. origin/master:suggestion/suggestion.pl: unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { In fact @status_constants should be a constant in Koha::Suggestion, to be used by other scripts, no ? Like we currently have Koha::Serials::MISSING_STATUSES -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155900&action=edit Bug 32942: (follow-up) Fix test I missed a test case when doing follow-ups before.. this patch catches that case and create the required authorized value to allow ModSuggestion to succeed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155901&action=edit Bug 32942L (follow-up) Fix typo Spelling typo fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155902&action=edit Bug 32942: (follow-up) Restore missing statuses At some stage we lost some of the core statuses. This patch simply adds them back into the list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, those three follow-ups should get us back up and running. I opted not so switch to a global constant.. I don't really see the benefit and even lookin at the example given by C4::Serials.. I don't actually see the constants referred to much. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155900|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155903&action=edit Bug 32942: (follow-up) Fix test I missed a test case when doing follow-ups before.. this patch catches that case and create the required authorized value to allow ModSuggestion to succeed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155903|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155904&action=edit Bug 32942: (follow-up) Fix test I missed a test case when doing follow-ups before.. this patch catches that case and create the required authorized value to allow ModSuggestion to succeed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155905&action=edit Bug 32942: (follow-up) Fix typo Spelling typo fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155902|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155906&action=edit Bug 32942: (follow-up) Restore missing statuses At some stage we lost some of the core statuses. This patch simply adds them back into the list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155901|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks for the follow-ups. Pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32942 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org