[Bug 34789] New: Fix typo in erm_eholdings_titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Bug ID: 34789 Summary: Fix typo in erm_eholdings_titles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: matt.blenkinsop@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com preceeding_publication_title_id should be preceding_publication_title_id This causes issues in importing KBART files for bug 34788 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe |com |.com Blocks| |34788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 [Bug 34788] Add the ability to import KBART files to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155607&action=edit Bug 34789: Database and API update Currently the erm_eholdings_titles table has a field called preceeding_publication_title_id. This should be preceding_publication_title_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155608&action=edit Bug 34789: DBIC file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155609&action=edit Bug 34789: Update usage throughout Koha modules and Vue components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155610&action=edit Bug 34789: Update unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Test plan: prove -v t/db_dependent/api/v1/erm_eholdings_titles.t Run cypress test suite -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155607|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 155730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155730&action=edit Bug 34789: Database and API update Currently the erm_eholdings_titles table has a field called preceeding_publication_title_id. This should be preceding_publication_title_id Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155608|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 155731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155731&action=edit Bug 34789: DBIC file Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155609|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 155732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155732&action=edit Bug 34789: Update usage throughout Koha modules and Vue components Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155610|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 155733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155733&action=edit Bug 34789: Update unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. After applying patches run: updatedatabase, dbic, yarn build 2. To run cypress tests: time perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only (hope this is the correct way to do this - from https://wiki.koha-community.org/wiki/User:Victor_Grousset_-_tuxayo/Setup_Koh... - see output - all cypress tests pass[1]) [1] Results from running Cypress tests: Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ KohaTable_spec.ts 00:03 1 1 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ ERM/Agreements_spec.ts 00:31 5 5 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ ERM/Dialog_spec.ts 00:09 4 4 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ ERM/Licenses_spec.ts 00:20 5 5 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ ERM/Packages_spec.ts 00:20 5 5 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ ERM/Searchbar_spec.ts 00:04 4 4 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ ERM/Titles_spec.ts 00:37 6 6 - - - │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 02:07 30 30 - - - Done in 139.81s. all good Running [koha-shell kohadev -c "touch testing.success"]... real 2m20.061s user 0m31.341s sys 0m18.387s -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155730|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155750&action=edit Bug 34789: Database and API update Currently the erm_eholdings_titles table has a field called preceeding_publication_title_id. This should be preceding_publication_title_id Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155731|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155751&action=edit Bug 34789: DBIC file Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155732|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155752&action=edit Bug 34789: Update usage throughout Koha modules and Vue components Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155733|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155753&action=edit Bug 34789: Update unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155754&action=edit Bug 34789: (QA follow-up) Improve output of database update * Adds description * Adds column names to success messages Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Matt, small things: * the DBIC file should be marked with [DO NOT PUSH] to make it stand out a bit more. * the db update was missing the description, fixed in follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Noted, thanks Cait! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #21 from Andrii Nugged <nugged@gmail.com> --- NOTE but it might be very urgent: I am making our regular "piloting production build", we're following 23.05, and here is the issue we just bumped into: ALTER TABLE erm_eholdings_titles RENAME COLUMN preceding_publication_title_id TO preceding_publication_title_id; This gives an atomic update error on older mariaDB because it appeared only: RENAME COLUMN: MariaDB starting with 10.5.2 Older compatible syntax probably should be: ALTER TABLE erm_eholdings_titles CHANGE COLUMN ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #22 from Andrii Nugged <nugged@gmail.com> --- ( ALTER TABLE erm_eholdings_titles CHANGE COLUMN preceeding_publication_title_id preceding_publication_title_id varchar(255) DEFAULT NULL ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- They are using preceeding_publication_title_id there: https://developer.ebsco.com/knowledge-services/holdingsiq/docs/downloading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #23)
They are using preceeding_publication_title_id there: https://developer.ebsco.com/knowledge-services/holdingsiq/docs/downloading
Fun... I looked it up - preceding seems to be UK spelling? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- The official NISO standard documentation for KBART uses "preceding" - see page 29 here: https://groups.niso.org/higherlogic/ws/public/download/16900/RP-9-2014_KBART... "preceeding" is an incorrect spelling, I think EBSCO need to change their docs! https://www.merriam-webster.com/dictionary/preceeding I'll add a follow-up to address Andrii's comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I'll also test the EBSCO import - the titles will probably need amending before storing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155887&action=edit Bug 34789: (follow-up) Fix atomic update file Atomic update file had a versioning issue - now changed to be compatible with older versions Please backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Tomas - see follow-up patch that needs pushing to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Matt Blenkinsop from comment #28)
Tomas - see follow-up patch that needs pushing to master
Pushed to master, thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- follow-up pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org