[Bug 14002] New: Show patron expiry date in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Bug ID: 14002 Summary: Show patron expiry date in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We currently don't show the expiry date of the patron on the OPAC detail page. This is an important date and we should display it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 40051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40051&action=edit Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40051|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 40052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40052&action=edit Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40052|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 40055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40055&action=edit Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40055|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40198&action=edit Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40199&action=edit Bug 14002: Display readonly values as plain text There is no need to display the cardnumber and expiration date values in a disabled input. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #5)
Created attachment 40199 [details] [review] Bug 14002: Display readonly values as plain text
There is no need to display the cardnumber and expiration date values in a disabled input.
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Katrin, What about this patch? I don't understand why the readonly values are displayed in a disabled input. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I copied mine from the cardnumber to be honest - will try to check your patch asap :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40198|0 |1 is obsolete| | Attachment #40199|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40405&action=edit [PASSED QA] Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40406&action=edit [PASSED QA] Bug 14002: Display readonly values as plain text There is no need to display the cardnumber and expiration date values in a disabled input. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org