[Bug 14870] New: Delete C4/Dates.pm from System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Bug ID: 14870 Summary: Delete C4/Dates.pm from System Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Bug to remove file C4/Dates.pm from system. With Bug 13813 we removed C4::Dates from a lot of files. However, there are many files left before we can delete C4/Dates.pm and resolve issues like Bug 12072 I think we should break down the task of weeding out C4::Dates to several Bugs that block this one. Files with C4::Dates (extracted from: git grep C4::Dates) C4/Calendar.pm C4/Circulation.pm C4/Debug.pm C4/Members.pm C4/Reports/Guided.pm C4/Reserves.pm C4/Search.pm C4/Serials.pm C4/Utils/DataTables.pm C4/Utils/DataTables/Members.pm C4/VirtualShelves/Page.pm acqui/histsearch.pl acqui/invoice.pl acqui/invoices.pl acqui/orderreceive.pl acqui/parcel.pl acqui/parcels.pl acqui/pdfformat/layout2pages.pm acqui/pdfformat/layout2pagesde.pm acqui/pdfformat/layout3pages.pm acqui/pdfformat/layout3pagesfr.pm acqui/transferorder.pl admin/aqbudgets.pl admin/aqcontract.pl admin/aqplan.pl admin/categorie.pl admin/smart-rules.pl catalogue/detail.pl cataloguing/additem.pl circ/bookcount.pl circ/circulation.pl circ/overdue.pl circ/pendingreserves.pl circ/reserveratios.pl circ/returns.pl debian/templates/plack.psgi installer/data/mysql/updatedatabase.pli labels/label-item-search.pl members/memberentry.pl members/moremember.pl members/printfeercpt.pl misc/cronjobs/batch_anonymise.pl misc/cronjobs/cleanup_database.pl misc/cronjobs/gather_print_notices.pl misc/cronjobs/overdue_notices.pl misc/cronjobs/serialsUpdate.pl misc/cronjobs/staticfines.pl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl misc/maintenance/fix_accountlines_date.pl misc/plack/koha.psgi opac/opac-alert-subscribe.pl opac/opac-ics.pl opac/opac-memberentry.pl opac/opac-reserve.pl opac/opac-search-history.pl opac/opac-serial-issues.pl opac/opac-showreviews.pl opac/opac-suggestions.pl plugins/plugins-home.pl plugins/run.pl reports/acquisitions_stats.pl reports/bor_issues_top.pl reports/borrowers_out.pl reports/borrowers_stats.pl reports/cat_issues_top.pl reports/dictionary.pl reports/guided_reports.pl reports/issues_avg_stats.pl reports/issues_stats.pl reports/itemslost.pl reports/reservereport.pl reports/reserves_stats.pl reports/serials_stats.pl reserve/request.pl serials/acqui-search-result.pl serials/checkexpiration.pl serials/routing-preview.pl serials/routing.pl serials/serial-issues.pl serials/serials-collection.pl serials/serials-edit.pl serials/showpredictionpattern.pl serials/subscription-add.pl serials/subscription-detail.pl serials/subscription-history.pl serials/subscription-renew.pl t/Dates.t t/db_dependent/Budgets.t t/db_dependent/Holds.t t/db_dependent/Koha_template_plugin_KohaDates.t t/db_dependent/Log.t t/db_dependent/NewsChannels.t tags/review.pl tools/batchMod.pl tools/exceptionHolidays.pl tools/export.pl tools/holidays.pl tools/import_borrowers.pl tools/newHolidays.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12072 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13813 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 [Bug 12072] New dateformat dd.mm.yyyy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7899 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899 [Bug 7899] Remove C4::Dates from C4::Circulation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14873 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14873 [Bug 14873] Remove C4::Dates from reserve/request.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14879 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14879 [Bug 14879] Remove C4::Dates from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14890 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14890 [Bug 14890] Remove C4::Dates from circ/bookcount.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14903 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 [Bug 14903] Remove C4::Dates from circ/circulation.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14916 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 [Bug 14916] Remove C4::Dates from circ/overdue.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14918 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14920 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 [Bug 14920] Remove C4::Dates from circ/reserveratios.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14922 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 [Bug 14922] Remove C4::Dates from cataloguing/additem.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14923 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 [Bug 14923] Remove C4::Dates from labels/label-item-search.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14924 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 [Bug 14924] Remove C4::Dates from members/memberentry.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14925 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 [Bug 14925] Remove C4::Dates from members/moremember.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14926 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 [Bug 14926] Remove C4::Dates from members/printfeercpt.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14928 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14931 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 [Bug 14931] Remove C4::Dates from files admin/aq*.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14929 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 [Bug 14929] Fix missing display of help page in contract management -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14929 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 [Bug 14929] Fix missing display of help page in contract management -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14946 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 [Bug 14946] Remove C4::Dates from files acqui/*.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14949 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14950 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 [Bug 14950] Remove C4::Dates from tools/batchMod.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14951 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 [Bug 14951] Remove C4::Dates from plugins/*.pl files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14954 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 [Bug 14954] Remove C4::Dates from holiday related files in folder tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14956 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 [Bug 14956] C4::Dates from files opac/*.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14960 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 [Bug 14960] Remove C4::Dates from files in misc/cronjobs (part 1) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14961 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 [Bug 14961] Remove C4::Dates from files reports/*_stats.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14965 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 [Bug 14965] Remove C4::Dates from 'lists' in folder reports -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14977 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14982 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 [Bug 14982] Remove C4::Dates from guided report wizard and dictionary -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14985 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 [Bug 14985] Remove C4::Dates from files in folder C4/*.pm (part one) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7899 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899 [Bug 7899] Remove C4::Dates from C4::Circulation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14995 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14996 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 [Bug 14996] Remove C4::Dates from tags/review.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14997 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 [Bug 14997] Remove C4::Dates from tools (import / export) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14998 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 [Bug 14998] Remove C4::Dates from installer and maintenance folders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #1 from Marc Véron <veron@veron.ch> --- With all the blocking Bugs pushed (latest is Bug 14998), the only remaining files should be: To be removed: C4/Dates.pm t/Dates.t To be changed: debian/templates/plack.psgi misc/plack/koha.psgi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14060 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #2 from Marc Véron <veron@veron.ch> --- 17 patches left to sign-off as of today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #3 from Marc Véron <veron@veron.ch> --- 13 patches left to sign-off as of today -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15087 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #4 from Marc Véron <veron@veron.ch> --- As of today - 7 patches left to sign-off - 1 signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15087 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 [Bug 15087] make dt_from_string return undef for '0000-00-00' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15087 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 [Bug 15087] Fix GetHardDueDate return value -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Marc Véron <veron@veron.ch> --- As of today depending on: Need Sign-off: 14954 14946 14960 14969 Signed-off 14985 14965 14998 14956 I switch to "Needs sign-off" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44595&action=edit Bug 14870 - Remove C4/Dates.pm from Koha Remove C4/Dates.pm form Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Marc I attached the patch for the near future. Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #8 from Marc Véron <veron@veron.ch> --- Hi Héctor, Thanks for the patch for removing C4/Dates.pm With all the patches applied, we can finally use the new date format from Bug 12072 However, before we remove C4/Dates.pm we have to make sure that the file really no longer is used or referenced. See my comment #1:
To be removed:
C4/Dates.pm t/Dates.t
To be changed:
debian/templates/plack.psgi misc/plack/koha.psgi
Additionally, we should do a final global search for C4::Dates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #9 from Marc Véron <veron@veron.ch> --- As of today, with following patches applied: 14960 (nso) 14969 (nqa) 14985 (nqa) 14954 (nqa) 14946 (nqa) 14998 (nqa) Rusults from: git grep 'C4::Dates': Form comment #1: C4/Dates.pm (remove) t/Dates.t (remove) debian/templates/plack.psgi (change to remove C4::Dates) misc/plack/koha.psgi (change to remove C4::Dates) Some stray C4::Dates found in: C4/Debug.pm (follow up) C4/Overdues.pm (follow up) C4/Serials.pm (follow up) circ/returns.pl (follow up) reports/borrowers_stats.pl (follow up) reports/guided_reports.pl (follow up) t/DateUtils.t (OK, it's in a comment only) misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl (remove? follow up?) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44612&action=edit Bug 14870 - Remove t/Dates.t from Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Marc. Please help me out with koha.psgi and plack.psgi I don't want to screw up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Héctor Eduardo Castro Avalos from comment #11)
Hi Marc. Please help me out with koha.psgi and plack.psgi I don't want to screw up.
Just remove it. It is only used for preloading it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #13 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44613&action=edit Bug 14870 - Remove C4::Dates from plack.psgi and koha.psgi Remove C4::Dates from .psgi files from preloaded modules, placing Koha::DateUtils instead -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #14 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #12)
Just remove it. It is only used for preloading it.
Done. But I place instead Koha::DateUtils, correct me if I'm wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #15 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #9) (...)
Some stray C4::Dates found in: (...) C4/Serials.pm (follow up) (...) Fixed in follow up to Bug 14969
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #16 from Marc Véron <veron@veron.ch> --- I will fix some remaining stray C4::Dates in follow-ups and/or a separate bug. Some stray C4::Dates found in: C4/Debug.pm (follow up) C4/Overdues.pm (follow up) circ/returns.pl (follow up) reports/borrowers_stats.pl (follow up) reports/guided_reports.pl (follow up) t/DateUtils.t (OK, it's in a comment only) misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl (remove? follow up?) Switching to "Needs sign-off" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #17 from Marc Véron <veron@veron.ch> --- C4/Overdues.pm fixed in followup in Bug 14985 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 44623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44623&action=edit Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl This patch removes 1 remaining / stray occurence of C4::Dates from circ/returns.pl To test: - Apply patch - Go to Home > Circulation > Check in - Verfiy that check-ins with overriding return dates work as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #19 from Marc Véron <veron@veron.ch> --- Created attachment 44625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44625&action=edit Bug 14870: (followup) Remove stray C4::Dates from reports files This patch removes stray C4::Dates from following files: reports/borrowers_stats.pl To test: Verify that C4::Dates is not used in the file reports/guided_reports.pl: To test: - Run a saved report with date input and with date range input, e.g. - Verify that you are asked for date range or date and that the results are the same as without patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 44626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44626&action=edit Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #21 from Marc Véron <veron@veron.ch> --- Still applies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It appears a few are missing. I tested this on top of: 14954 14946 I found those references outside the release notes: C4/Serials.pm:$planneddate is a C4::Dates object. misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl:use C4::Dates; serials/acqui-search-result.pl:use C4::Dates qw/format_date/; t/DateUtils.t:# C4::Dates allowed 00th of the month 2 of those appear to be comments - but please check. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15076 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looked a bit further: 1) C4/Serials.pm:$planneddate is a C4::Dates object. - POD, should be corrected 2) misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl:use C4::Dates; - Covered by bug 15076. We need to make a decision there. 3) serials/acqui-search-result.pl:use C4::Dates qw/format_date/; - This one needs to be fixed, has a few date_format. 4) t/DateUtils.t:# C4::Dates allowed 00th of the month - I think that can probably be ignored Looking for format_date I find one more ocurrence: 5) C4/Log.pm: $data->{day} = format_date($data->{timestamp}); - Looks like this was missed. format_date_in_iso: 6) C4/Items.pm: $datelastseen = format_date_in_iso($datelastseen); 7) t/db_dependent/Items/GetItemsForInventory.t: $datelastseen = format_date_in_iso($datelastseen); 8) tools/koha-news.pl: #$new->{'expirationdate'}=format_date_in_iso($new->{'expirationdate'}); Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #24 from Marc Véron <veron@veron.ch> --- Created attachment 44943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44943&action=edit Bug 14969: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #25 from Marc Véron <veron@veron.ch> --- Created attachment 44944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44944&action=edit Bug 14870: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it --- Comment #26 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi, I found that in reports/guided_reports.pl C4:Dates is still present: 359 # If the range values are dates 360 if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ C4::Dates->regexp('syspref')) { 361 $fromvalue = C4::Dates->new($fromvalue)->output("iso"); 362 $tovalue = C4::Dates->new($tovalue)->output("iso"); 363 } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #27 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi, I found that in reports/guided_reports.pl C4:Dates is still present.
From lines 359 to 363:
# If the range values are dates if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ C4::Dates->regexp('syspref')) { $fromvalue = C4::Dates->new($fromvalue)->output("iso"); $tovalue = C4::Dates->new($tovalue)->output("iso"); } A new bug or you fix here ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #28 from Marc Véron <veron@veron.ch> --- Hi Zeno, thakns for testing. I can not find C4::Dates in reports/guided_reports.pl Git grep 'C4::Dates' only gives results only in misc/release_notes/release_notes_3_22_0.txt I applyed the patches after a recent git pull: HEAD is now at 87e7d55 Bug 15199: t/db_dependent/Review.t should not depend on existing data -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #29 from Marc Véron <veron@veron.ch> --- Switching back to NSO -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #30 from Marc Véron <veron@veron.ch> --- Created attachment 44954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44954&action=edit Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl To test: - Apply patch - Check code for uses of C4::Dates (date_format) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15076 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #31 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Zeno Tajoli from comment #27)
Hi, I found that in reports/guided_reports.pl C4:Dates is still present.
From lines 359 to 363:
# If the range values are dates if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ C4::Dates->regexp('syspref')) { $fromvalue = C4::Dates->new($fromvalue)->output("iso"); $tovalue = C4::Dates->new($tovalue)->output("iso"); }
A new bug or you fix here ?
A previous attachment in this bug fixed it up <http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44625&action=diff> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44997&action=edit [SIGNED OFF] remove C4/Dates.pm from Koha http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44997|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44998&action=edit [SIGNED OFF] remove C4/Dates.pm from Koha http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44999&action=edit [SIGNED OFF] Bug 14870 - Remove t/Dates.t from Koha Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45000&action=edit [SIGNED OFF] Remove C4::Dates from plack.psgi and koha.psgi Remove C4::Dates from .psgi files from preloaded modules, placing Koha::DateUtils instead http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45001&action=edit [SIGNED OFF] Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl This patch removes 1 remaining / stray occurence of C4::Dates from circ/returns.pl To test: - Apply patch - Go to Home > Circulation > Check in - Verfiy that check-ins with overriding return dates work as before. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45002&action=edit [SIGNED OFF] Bug 14870: (followup) Remove stray C4::Dates from reports files This patch removes stray C4::Dates from following files: reports/borrowers_stats.pl To test: Verify that C4::Dates is not used in the file reports/guided_reports.pl: To test: - Run a saved report with date input and with date range input, e.g. - Verify that you are asked for date range or date and that the results are the same as without patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45003&action=edit [SIGNED OFF] Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45004&action=edit [SIGNED OFF] Bug 14870: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> serials/acqui-search-results.pl looks like it should be revisited, containing code that might not be needed. Searching a vendor in serials still works witout a problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45005&action=edit [PASSED QA] Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl To test: - Apply patch - Check code for uses of C4::Dates (date_format) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45006&action=edit Bug 14870: QA follow-up - fixing tiny typo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44623|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44626|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45007&action=edit Bug 14870: Remove C4/Dates.pm from Koha http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45008&action=edit Bug 14870: Remove t/Dates.t from Koha Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45009&action=edit Bug 14870: Remove C4::Dates from plack.psgi and koha.psgi Remove C4::Dates from .psgi files from preloaded modules, placing Koha::DateUtils instead http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45010&action=edit Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl This patch removes 1 remaining / stray occurence of C4::Dates from circ/returns.pl To test: - Apply patch - Go to Home > Circulation > Check in - Verfiy that check-ins with overriding return dates work as before. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45011&action=edit Bug 14870: (followup) Remove stray C4::Dates from reports files This patch removes stray C4::Dates from following files: reports/borrowers_stats.pl To test: Verify that C4::Dates is not used in the file reports/guided_reports.pl: To test: - Run a saved report with date input and with date range input, e.g. - Verify that you are asked for date range or date and that the results are the same as without patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45012&action=edit Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45013&action=edit Bug 14870: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> serials/acqui-search-results.pl looks like it should be revisited, containing code that might not be needed. Searching a vendor in serials still works witout a problem. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45014&action=edit Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl To test: - Apply patch - Check code for uses of C4::Dates (date_format) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45006|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 45015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45015&action=edit Bug 14870: QA follow-up - fixing tiny typo Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #44998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45001|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45007|Bug 14870: Remove |[PASSED QA] Bug 14870: description|C4/Dates.pm from Koha |Remove C4/Dates.pm from | |Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45008|Bug 14870: Remove t/Dates.t |[PASSED QA] Bug 14870: description|from Koha |Remove t/Dates.t from Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45009|Bug 14870: Remove C4::Dates |[PASSED QA] Bug 14870: description|from plack.psgi and |Remove C4::Dates from |koha.psgi |plack.psgi and koha.psgi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45010|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove stray C4::Dates from |(followup) Remove stray |circ/returns.pl |C4::Dates from | |circ/returns.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45011|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove stray C4::Dates from |(followup) Remove stray |reports files |C4::Dates from reports | |files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45012|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove mention of C4::Dates |(followup) Remove mention |from C4/Debug.pm |of C4::Dates from | |C4/Debug.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45013|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove stray C4::Dates |(followup) Remove stray | |C4::Dates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45014|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove superfluous |(followup) Remove |C4::Dates from |superfluous C4::Dates from |fix_accountlines_rmdupfines |fix_accountlines_rmdupfines |_bug8253.pl |_bug8253.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45015|Bug 14870: QA follow-up - |[PASSED QA] Bug 14870: QA description|fixing tiny typo |follow-up - fixing tiny | |typo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- In the words of cait: Die C4::Dates, die! Code all checks out, tests all pass and my testing also showed nothing untoward.. passing! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #52 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Hector and Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Bug 14870 depends on bug 14997, which changed state. Bug 14997 Summary: Remove C4::Dates from tools (import / export) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Bug 14870 depends on bug 14924, which changed state. Bug 14924 Summary: Remove C4::Dates from members/memberentry.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org