[Bug 28575] New: Add ability to choose if lost fee is refunded based on when lost fee was paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Bug ID: 28575 Summary: Add ability to choose if lost fee is refunded based on when lost fee was paid off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In bug 20815 we added the NoRefundOnLostReturnedItemsAge system preference to block lost item refunds if the item was lost more than X daya ago. Many libraries would like a comparable system to block refund if the lost item fee has been paid in full more than X days ago. Further, even more libraries have asked for the ability to simply not refund paid lost items at all (they only want to refund/forgive lost fees that are not yet paid). Enabling this new syspref to block refunds on lost items paid off more than 0 days ago would support this behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20815 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Christofer Zorn <christofer.zorn@ajaxlibrary.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn@ajaxlibrary | |.ca --- Comment #1 from Christofer Zorn <christofer.zorn@ajaxlibrary.ca> --- This would be a cool enhancement to see ... we want to prevent unrealized credits from popping up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 saylett <saylett@spanishfork.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saylett@spanishfork.org --- Comment #2 from saylett <saylett@spanishfork.org> --- I agree that this would be a great enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167567&action=edit Bug 28575: Add new syspref 'NoRefundOnLostFinesPaidAge' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167568&action=edit Bug 28575: Stop lost fine refund if fine is older than syspref value Test plan: 1) Apply patch and reset_all 2) Checkout an item to a patron 3) Mark that item as lost 4) Add a manual invoice for that item's barcode to the patron's account 5) Pay that fine in the Make a payment tab 6) In system preferences, search for NoRefundOnLostFinesPaidAge 7) Set this to -1. I use this value here to avoid needing to go into the database to change the date of the payment we made in step 5. Any fines older than -1 days (i.e. all fines) will be caught by the syspref which is what we want to test) 8) Check in the item 9) The check in message should display "Any lost item fees for this item will remain on the patron's account." 10) Navigate to the Patron's account and confirm that no credit has been added and that the lost fee has therefore not been refunded 11) Run unit test: prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167569&action=edit Bug 28575: Add unit tests prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I'm not quite sure if this is behaving as desired or not. So, slightly different test plan to get more granular: 1: apply patch and reset_all 2: set WhenLostChargeReplacementFee=charge, NoRefundOnLostFinesPaidAge=1, circ rules set to refund paid lost fees when item returned 3: check out 5 items to a patron, mark all 5 lost, incurring 5 lost charges 4: make payments and edit the account_offsets.created_on date for them via the database such that your five charges match this: -- charge 1: fully paid 1+ days ago -- charge 2: partially paid 1+ days ago -- charge 3: partially paid 1+ days ago, remaining payment < 1 day ago -- charge 4: full payment < 1 day ago -- charge 5: partial payment < 1 day ago 5: Check all items in I got no refund on charge 1, as expected. I got no refund on charge 2 -- the system preference says this applies to charges paid in full, should it apply here?. I got no refund on charge 3 -- I'm not sure if I should have expect a full refund because my charge reached $0 outstanding within the 1 day window, or just a refund of the payment that happened within the 1 day window. What actually happened was I got no refund at all because some portion of the charge had been paid more than a day ago. Charges 4 and 5 refunded the portion of the charge I had paid, as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- If nothing else, the system preference needs to be reworded to accurately reflect that it's not just for fully paid charges. Additionally, I don't think the message "Any lost item fees for this item will remain on the patron's account." conveys accurately what is happening here. We're not leaving fees on their account, we're leaving payments on their account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #8 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Andrew Fuerste-Henry from comment #7)
If nothing else, the system preference needs to be reworded to accurately reflect that it's not just for fully paid charges.
Additionally, I don't think the message "Any lost item fees for this item will remain on the patron's account." conveys accurately what is happening here. We're not leaving fees on their account, we're leaving payments on their account.
Our desired functionality here is that when a lost item is found the entire paid portion of the lost fee should be refunded unless the payment through which the debit reached $0 outstanding was more than X days ago. That would mean: - this system preference would have no bearing on refunds on items that have not reached $0 outstanding - if a lost item was partially paid >X days ago, then paid off the rest of the way <X days ago, and then returned today, the full paid amount would be refunded All that said, I don't know if we have a great way to determine the date on which a debit reached $0 outstanding. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167567|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167621&action=edit Bug 28575: Add new syspref 'NoRefundOnLostFinesPaidAge' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167568|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167622&action=edit Bug 28575: Stop lost fine refund if fine is older than syspref value Test plan: 1) Apply patch and reset_all 2) Checkout an item to a patron 3) Mark that item as lost 4) Add a manual invoice for that item's barcode to the patron's account 5) Pay that fine in the Make a payment tab 6) In system preferences, search for NoRefundOnLostFinesPaidAge 7) Set this to -1. I use this value here to avoid needing to go into the database to change the date of the payment we made in step 5. Any fines older than -1 days (i.e. all fines) will be caught by the syspref which is what we want to test) 8) Check in the item 9) The check in message should display "Any lost item fees for this item will remain on the patron's account." 10) Navigate to the Patron's account and confirm that no credit has been added and that the lost fee has therefore not been refunded 11) Run unit test: prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167623&action=edit Bug 28575: Add a new check-in message for the new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167569|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167624&action=edit Bug 28575: Add unit tests prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Hi Andrew, thanks for the feedback and for testing! I've made changes as you suggested, so it should now only operate on charges that have a £0 balance. I've also updated the syspref description and added a new checkin message to account for this as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167624|0 |1 is obsolete| | --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167627&action=edit Bug 28575: Add unit tests prove t/db_dependent/Circulation.t Sponsored-by: Rapid City Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167621|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 167635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167635&action=edit Bug 28575: Add new syspref 'NoRefundOnLostFinesPaidAge' Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167622|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 167636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167636&action=edit Bug 28575: Stop lost fine refund if fine is older than syspref value Test plan: 1) Apply patch and reset_all 2) Checkout an item to a patron 3) Mark that item as lost 4) Add a manual invoice for that item's barcode to the patron's account 5) Pay that fine in the Make a payment tab 6) In system preferences, search for NoRefundOnLostFinesPaidAge 7) Set this to -1. I use this value here to avoid needing to go into the database to change the date of the payment we made in step 5. Any fines older than -1 days (i.e. all fines) will be caught by the syspref which is what we want to test) 8) Check in the item 9) The check in message should display "Any lost item fees for this item will remain on the patron's account." 10) Navigate to the Patron's account and confirm that no credit has been added and that the lost fee has therefore not been refunded 11) Run unit test: prove t/db_dependent/Circulation.t Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167623|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 167637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167637&action=edit Bug 28575: Add a new check-in message for the new syspref Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167627|0 |1 is obsolete| | --- Comment #18 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 167638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167638&action=edit Bug 28575: Add unit tests prove t/db_dependent/Circulation.t Sponsored-by: Rapid City Public Library Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #19 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- This worked as desired and as described. The wording at checkin is clear and accurate. I'm still unsure of the wording on the syspref, but figured that could get addressed moving forward. You've got "Don't refund lost fees if the fee was paid in full or if the balance of the fee was paid more than X days ago." Strictly speaking, the code says "Don't refund lost fees if the fee is at amountoutstanding=0 and the most recently applied credit was applied more than X days ago." Maybe we could go with "Don't refund lost fees if the fee was paid in full and the most recently applied credit was applied more than X days ago"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #20 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I wonder how this will play with lostreturn settings of: Refund lost item charge and charge new overdue fine Refund lost item charge and restore overdue fine The new code returns from the subroutine before hitting these, but I am not sure how the logic should work? If I paid the lost fee more than X days ago, and we aren't refunding, then do we expect to sustain those charges? I think we should have additional tests in t/db_dependent/Koha/Item.t for _set_found_trigger directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #21 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Nick Clemens (kidclamp) from comment #20)
I wonder how this will play with lostreturn settings of: Refund lost item charge and charge new overdue fine Refund lost item charge and restore overdue fine
The new code returns from the subroutine before hitting these, but I am not sure how the logic should work?
If I paid the lost fee more than X days ago, and we aren't refunding, then do we expect to sustain those charges?
The ability to restore overdues when refunding a lost item charge was added in bug 23091. Discussion there suggests we should *not* reinstate overdues when a lost fee is not refunded due to having been paid too long ago. Bug 20815 allows one to prevent refunds based on how long ago the item became lost. How does it handle whether or not overdues are reinstated/recreated? Consistency seems ideal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> ---
Bug 20815 allows one to prevent refunds based on how long ago the item became lost. How does it handle whether or not overdues are reinstated/recreated? Consistency seems ideal.
The syspref this introduces (NoRefundOnLostReturnedItemsAge) is processed right at the start of the _set_found_trigger method so returns before any overdues are handled - looks like they're not considered at all for that system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168146&action=edit Bug 28575: (QA follow-up): Add further unit tests This patch adds further unit tests for the messaging in _set_found_trigger prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167635|0 |1 is obsolete| | --- Comment #24 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172252&action=edit Bug 28575: Add new syspref 'NoRefundOnLostFinesPaidAge' Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167636|0 |1 is obsolete| | --- Comment #25 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172253&action=edit Bug 28575: Stop lost fine refund if fine is older than syspref value Test plan: 1) Apply patch and reset_all 2) Checkout an item to a patron 3) Mark that item as lost 4) Add a manual invoice for that item's barcode to the patron's account 5) Pay that fine in the Make a payment tab 6) In system preferences, search for NoRefundOnLostFinesPaidAge 7) Set this to -1. I use this value here to avoid needing to go into the database to change the date of the payment we made in step 5. Any fines older than -1 days (i.e. all fines) will be caught by the syspref which is what we want to test) 8) Check in the item 9) The check in message should display "Any lost item fees for this item will remain on the patron's account." 10) Navigate to the Patron's account and confirm that no credit has been added and that the lost fee has therefore not been refunded 11) Run unit test: prove t/db_dependent/Circulation.t Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167637|0 |1 is obsolete| | --- Comment #26 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172254&action=edit Bug 28575: Add a new check-in message for the new syspref Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167638|0 |1 is obsolete| | --- Comment #27 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172255&action=edit Bug 28575: Add unit tests prove t/db_dependent/Circulation.t Sponsored-by: Rapid City Public Library Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168146|0 |1 is obsolete| | --- Comment #28 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172256&action=edit Bug 28575: (QA follow-up): Add further unit tests This patch adds further unit tests for the messaging in _set_found_trigger prove t/db_dependent/Koha/Item.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #29 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172257&action=edit Bug 28575: (QA follow-up) Tidy and test count Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #30 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172258&action=edit Bug 28575: (QA follow-up) Tidy more Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Database update (solved) Please use the standardized example success messages when writing your database updates from the bottom of the skeleton.pl file. "Added system preference '...'" I updated it when moving the atomicupdate to dbrevs. 2) Question (not blocker) I was wondering when testing this if that and other preferences relating to the lost fee should be in the "lost item policy" section instead of the "fines policy" section. Just leaving this here to maybe get some opinions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This adds a new system release notes| |preference | |`NoRefundOnLostFinesPaidAge | |` that allows to control | |how long after a lost fee | |has been paid a refund will | |be issued if the item is | |found and returned. --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please check if I worded the release notes correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a new system |This adds a new system release notes|preference |preference |`NoRefundOnLostFinesPaidAge |`NoRefundOnLostFinesPaidAge |` that allows to control |` that allows the user to |how long after a lost fee |control how long after a |has been paid a refund will |lost fee has been paid a |be issued if the item is |refund will be issued if |found and returned. |the item is found and | |returned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #34)
Please check if I worded the release notes correctly.
I've made the most pedantic of corrections :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #35)
(In reply to Katrin Fischer from comment #34)
Please check if I worded the release notes correctly.
I've made the most pedantic of corrections :)
I am all for pedantic corrections ;D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1054 CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #37 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Added to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org