https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #1 from Laurence Rault <laurence.rault@biblibre.com> --- The trouble is that now the budgeted cost (ecost) is calculated based on Replacement cost (rrp) and not (not only in fact) from vendor price (listprice) anymore. And I think it may be bug : When you change rrp in an order, budgeted cost does not change in the form, but after validation, values in the table for budgeted cost are re-calculated against the modified rrp. Maybe we should consider alternatives : 1) make the budgeted cost only calculated from vendor price ; if rrp is modified, no effect on ecost (as it is still the case in Koha 3.22). And then make the rrp editable through the whole workflow. Would it be enough ? 2) I agree with your proposition, with some questions : - what would be the difference between Vendor price and Retail price ? - I am not at all familiar with EDI, but is the replacementprice sent or received to/by the vendor ? I think vendor price and/or actual cost should be (maybe the are already). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18736 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Bug 18639 depends on bug 13321, which changed state. Bug 13321 Summary: Fix tax and prices calculation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70214&action=edit Bug 18639 - Schema updates (DO NOT PUSH) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70216&action=edit Bug 18639 - Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70213|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 76867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76867&action=edit Bug 18639 - Add replacementprice field to aqorders Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70215|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 76869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76869&action=edit Bug 18639 - Add replacementprice field to acquisitions workflow To test: 0 - Apply patches and updatedatabase 1 - Add an order to a basket 2 - You should note new 'Retail price field' 3 - You should have a separate 'Replacement price' field 4 - Enter values and ensure they are saved as expected 5 - In the basket you should see the replacement price 6 - Modify order and ensure value is loaded and saved correctly 7 - Add and cancle an order and esure replacement price shows/saves 8 - Close basket 9 - Receive an order 10 - You should be able to edit replacement price 11 - 'retail price' field is not editable 12 - Check associated item, replacement price in item should be updated 13 - Cancel receipt, check item. receive again with new replacement price, check item 14 - Price should be correctly updated 15 - Finish receipt, value should show in table 16 - Test with receive from file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 76871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76871&action=edit Bug 18639 Use replacementprice when creating order from quote Updates column name from rrp -> replacementprice when creating order from EDI QUOTE message Also ensure other rrp_tax* fields populated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All seems to work as expected and seems to make sense. I look the liberty of re-basing it against master whilst signing off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #15)

Moving to enh Please explain why it should be seen as a bugfix.

The naming and use of this field has caused a lot of confusion for libraries - They enter a price here, expecting it to be used as the 'replacementprice' in the item record, however, it is used as the cost for the order. They generally expect the cost to be the vendor price or something else. I consider a bug as it doesn't behave in the manner expected by the end user. Changes on 13321 also changed the way fields behaved (rrp is now basis for order calculation) and this restores some functionality that was expected by users. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- If I had my QA hat on, I'd be asking for a corresponding documentation update patch linked to here (as a merge request on the gitlab koha-manual) and some release notes text summarising the change. I'd also be interested to understand whether we ought to also include a DB update script which moved the rrp value's into replacementprice field as that's what the functional change appears to do. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As it includes database changes and such I would not backport it. I think it's somewhat in a grey area between enh and bug. Too much of a change for a backport is my feel, but not a strict enh either. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some notes from reading through the bug and code review: 1) Leftover warn in finishreceive.pl +$replacementprice = Koha::Number::Price->new( $replacementprice )->unformat(); +warn "Replacement $replacementprice"; 2) Database update I also wonder if we should prefill replacementprice from rrp. We could argue that not all libraries will want it to be set to rrp by default, especially as it would change the behaviour for pending orders. 3) Notes for for the release notes would be great. Nick? 4) Question: Why not allow editing of retail price later on? In case of a typo you'd have to reopen the basket and that will mess with the order dates and such... wouldn't it be easier to leave it editable? I can remove the warn in a follow-up, still have to finish testing of the behaviour and calculations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch attempts to release notes| |remove some confusion as | |the 'Replacement price/rrp" | |field was being used as | |retail price during | |ordering process, but for | |item replacement price when | |receiving. | | | |This patch | |splits these fields so that | |each may be set | |independently. RRP will be | |used to determine costs | |while ordering, and | |replacement price will | |populate the items | |replacement price upon | |receiving. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thinking about it some more... maybe the better option would be to fill in the field in the order form automatically (rrp = replacement cost), and then allow it to be adjusted. That would probably give the most control over the field and libraries could choose 0/empty. My worry is adding more work/steps - with the current patch you have added steps to get to the same result as before. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76867|0 |1 is obsolete| | Attachment #76868|0 |1 is obsolete| | Attachment #76869|0 |1 is obsolete| | Attachment #76870|0 |1 is obsolete| | Attachment #76871|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78184&action=edit Bug 18639 - Add replacementprice field to aqorders Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78186&action=edit Bug 18639 - Add replacementprice field to acquisitions workflow To test: 0 - Apply patches and updatedatabase 1 - Add an order to a basket 2 - You should note new 'Retail price field' 3 - You should have a separate 'Replacement price' field 4 - Enter values and ensure they are saved as expected 5 - In the basket you should see the replacement price 6 - Modify order and ensure value is loaded and saved correctly 7 - Add and cancle an order and esure replacement price shows/saves 8 - Close basket 9 - Receive an order 10 - You should be able to edit replacement price 11 - 'retail price' field is not editable 12 - Check associated item, replacement price in item should be updated 13 - Cancel receipt, check item. receive again with new replacement price, check item 14 - Price should be correctly updated 15 - Finish receipt, value should show in table 16 - Test with receive from file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78188&action=edit Bug 18639 Use replacementprice when creating order from quote Updates column name from rrp -> replacementprice when creating order from EDI QUOTE message Also ensure other rrp_tax* fields populated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78191&action=edit Bug 18639: Alter DB update to populate replacementprice from rpp initially -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch attempts to |This patch attempts to release notes|remove some confusion as |remove some confusion as |the 'Replacement price/rrp" |the 'Replacement price/rrp' |field was being used as |field was being used as |retail price during |retail price during |ordering process, but for |ordering process, but for |item replacement price when |item replacement price when |receiving. |receiving. | | |This patch |This patch |splits these fields so that |splits these fields so that |each may be set |each may be set |independently. RRP will be |independently. RRP will be |used to determine costs |used to determine costs |while ordering, and |while ordering, and |replacement price will |replacement price will |populate the items |populate the items |replacement price upon |replacement price upon |receiving. |receiving. --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- When you go back and modify the order, the replacement cost ist not properly formatted. 113.00 shows as 113.000000. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 78250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78250&action=edit Bug 18639: Schema updates (DO NOT PUSH) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 78252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78252&action=edit Bug 18639: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78189|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 78254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78254&action=edit Bug 18639: (follow-up) Populate replacement price from list price during ordering Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 78256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78256&action=edit Bug 18639: (QA follow-up) Fix formatting of replacement cost when modifying an order -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21324 [Bug 21324] Missing aoColumns definition in acqui/parcel receivedt table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79789&action=edit Bug 18639: (follow-up) Remove debugging code -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 kholt@roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholt@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.