https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #20)
Some notes from reading through the bug and code review: 1) Leftover warn in finishreceive.pl
Indeed, apologies
2) Database update I also wonder if we should prefill replacementprice from rrp. We could argue that not all libraries will want it to be set to rrp by default, especially as it would change the behaviour for pending orders.
I personally don't like the idea, it would preserve current behaviour for orders, but I think we are trying to chnage that behaviour :-) I can be swayed here though as I am not sure the bets path - maybe just cover in release notes and allow libraries to decide
3) Notes for for the release notes would be great. Nick?
Sure
4) Question: Why not allow editing of retail price later on? In case of a typo you'd have to reopen the basket and that will mess with the order dates and such... wouldn't it be easier to leave it editable?
It is not editable before this patch, this simply preserves that behaviour - it can be modified, but that is for a future bug
I can remove the warn in a follow-up, still have to finish testing of the behaviour and calculations.
Thank you! Let me know what you find :-) -- You are receiving this mail because: You are watching all bug changes.