[Bug 39346] New: Only 20 supplementary fields are usable in Agreements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Bug ID: 39346 Summary: Only 20 supplementary fields are usable in Agreements Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com In administration, create 25 supplementary fields for ERM Agreements In ERM module, create an agreement : only 20 of the supplementary fields will be displayed It must be an issue with API call? Maybe it affects also other parts of Koha? If so it should be fixed everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Only 20 supplementary |Only 20 supplementary |fields are usable in |fields can be added to an |Agreements |agreement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Only 20 supplementary |Only 20 additional fields |fields can be added to an |can be added to an |agreement |agreement --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We use "additional fields" as the English term in the staff interface, just trying to make this stand out a bit more in result lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As a workaround, you can try to change RESTdefaultPageSize to a higher value and see if that fixes the issue temporarily. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 --- Comment #3 from Mathieu Saby <mathsabypro@gmail.com> --- I am just testing the module, no rush for a fix... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |35287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 [Bug 35287] Add additional fields support to ERM licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179384&action=edit Bug 39346: Display all additional fields getAll should call getAll, not get, or we lose the _per_page=-1 parameter. Test plan: Have more than 20 additional fields for agreements Create and agreement: => Notice that with this patch, all the fields are displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 39346 Bug 39346 - Only 20 additional fields can be added to an agreement 179384 - Bug 39346: Display all additional fields Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39346: Display all additional fields Using index info to reconstruct a base tree... A koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/fetch/additional-fields-api-client.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/fetch/additional-fields-api-client.js error: Failed to merge in the changes. Patch failed at 0001 Bug 39346: Display all additional fields Testing notes (using KTD): 1. The workaround suggested in comment #2 does work: change RESTdefaultPageSize to a higher value. 2. To add additional fields: - Go to: Koha administration > Additional parameters > Additional fields > E-resource management > Agreements (erm_agreements) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179384|Bug 39346: Display all |[24.11] Bug 39346: Display description|additional fields |all additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179420&action=edit Bug 39346: Display all additional fields getAll should call getAll, not get, or we lose the _per_page=-1 parameter. Test plan: Have more than 20 additional fields for agreements Create and agreement: => Notice that with this patch, all the fields are displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179420|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 179424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179424&action=edit Bug 39346: Display all additional fields getAll should call getAll, not get, or we lose the _per_page=-1 parameter. Test plan: Have more than 20 additional fields for agreements Create and agreement: => Notice that with this patch, all the fields are displayed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 --- Comment #8 from David Nind <david@davidnind.com> --- Updated testing notes (using KTD): 1. The workaround suggested in comment #2 does work: change RESTdefaultPageSize to a higher value. 2. To add additional fields: - Go to: Koha administration > Additional parameters > Additional fields > E-resource management > Agreements (erm_agreements) 3. After applying the patch: - yarn build - restart_all - clear your browser cache -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes adding a new release notes| |agreement in the ERM | |module, where there are | |more than 20 additional | |fields. All additional | |fields are now listed, not | |just the first 20. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179424|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 180445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180445&action=edit Bug 39346: Display all additional fields getAll should call getAll, not get, or we lose the _per_page=-1 parameter. Test plan: Have more than 20 additional fields for agreements Create and agreement: => Notice that with this patch, all the fields are displayed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Bug 39346 depends on bug 35287, which changed state. Bug 35287 Summary: Add additional fields support to ERM licenses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38993 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38993 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org