[Bug 39000] New: "Encoding errors" block on detail page hurt the eyes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Bug ID: 39000 Summary: "Encoding errors" block on detail page hurt the eyes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 35402 https://snipboard.io/wUmV50.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- We lost this: -.bg-danger { - background-color: #f2dede -} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177349&action=edit Bug 39000: Restore bg-danger color In ktd 369 will show the "Encoding error" block: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 The background color has changed this the bootstrap update and now looks ugly. This patch reuse the same color (#f2dede) we had before the upgrade -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177349|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 177369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177369&action=edit Bug 39000: Restore bg-danger color In ktd 369 will show the "Encoding error" block: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 The background color has changed this the bootstrap update and now looks ugly. This patch reuse the same color (#f2dede) we had before the upgrade Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38519 CC| |david@davidnind.com, | |oleonard@myacpl.org --- Comment #4 from David Nind <david@davidnind.com> --- I've signed off and added related bug 38519. Shouldn't the class be changed to match the Bootstrap 5 classes?[1] Will leave Owen to comment on that! Changes to classes - screenshot of the colours: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174935 David Testing notes: 1. After applying the patch, rebuild the css: yarn build Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38519 [Bug 38519] Improve contrast of Bootstrap alerts and text background classes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | QA Contact|testopia@bugs.koha-communit |oleonard@myacpl.org |y.org | CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177369|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177575&action=edit Bug 39000: Restore bg-danger color In ktd 369 will show the "Encoding error" block: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 The background color has changed this the bootstrap update and now looks ugly. This patch reuse the same color (#f2dede) we had before the upgrade Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This does look much better - we could use $red-100 instead if we want to stick with the defined colors, but others have specific values too so seems okay -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from David Cook <dcook@prosentient.com.au> --- *** Bug 39102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone. No eyes will be hurt anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@openfifth.c | |o.uk --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- This causes the red to be barely readable when used in the text-danger context. For reference, visit the following: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IndependentBranches&ok=Search You can't read the warning under 'IndependentBranches' anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As this has already been released, should we move to a new bug for further fixes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39274 --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Katrin Fischer from comment #11)
As this has already been released, should we move to a new bug for further fixes?
I encountered this on 24.11.x. It appears main has this fixed from bug 39274. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org