[Bug 16182] New: Make phone number clickable to call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Bug ID: 16182 Summary: Make phone number clickable to call Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Email addresses are clickable on member detail pages. It would be good to have phone numbers clickable in the same way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49747&action=edit Bug 16182: Make phone number clickable to call To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Should the SMS number link use '<a href="sms: ' instead? Failing because there is a typo in moremember.tt on line 225: <a href="te: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49747|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50045&action=edit Bug 16182: Make phone number clickable to call EDIT: fixing typo, changing sms number from tel: to sms: To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50045|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 50053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50053&action=edit Bug 16182: Make phone number clickable to call EDIT: fixing typo, changing sms number from tel: to sms: To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not we make these links visible/clickable only for mobile devices? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #5)
Should not we make these links visible/clickable only for mobile devices?
I can click them from my macbook, it opens up FaceTime I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I get """ The address wasn't understood Iceweasel doesn't know how to open this address, because one of the following protocols (tel) isn't associated with any program or is not allowed in this context. You might need to install other software to open this address. """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
Should not we make these links visible/clickable only for mobile devices?
Some mobile devices may not need the link and discover that it is a phone number anyway. If you install a app/plugin on your desktop, you can make this work too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50053|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 50569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50569&action=edit Bug 16182: Make phone number clickable to call EDIT: fixing typo, changing sms number from tel: to sms: To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Should be in the May 2016 release. Danke Aleisha! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org