https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16281 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50303&action=edit Bug 16281: Remove the use of 'onclick' from Reports module To test: 1) Go to Reports -> Dictionary a) Attempt to delete a definition. Confirm the Ok and cancel buttons in confirm dialog work as expected 2) Go to Reports -> Build new a) On each step of building a report, confirm the back button works as expected b) Confirm add column and delete column on step 3 works as expected 3) Confirm deleting a report from the toolbar triggers confirm dialog and it works as expected 4) Create a report with an SQL error and run it. Confirm that the 'Return to previous page' link works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16281 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- You don't need to add a new "confirmDel()" function. One is defined in staff-global.js. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16281 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50303|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50548&action=edit Bug 16281: Remove the use of 'onclick' from Reports module EDIT: Removing unnecessary functions To test: 1) Go to Reports -> Dictionary a) Attempt to delete a definition. Confirm the Ok and cancel buttons in confirm dialog work as expected 2) Go to Reports -> Build new a) On each step of building a report, confirm the back button works as expected b) Confirm add column and delete column on step 3 works as expected 3) Confirm deleting a report from the toolbar triggers confirm dialog and it works as expected 4) Create a report with an SQL error and run it. Confirm that the 'Return to previous page' link works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16281 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50586&action=edit Bug 16281 [Follow-up] Remove the use of "onclick" from Reports module This minor follow-up adds a dummy href attribute to the "Return to the previous page" link so that the link behaves like a link. A "preventDefault()" is added to the goback() function to keep the "#" link from triggering a page jump. To test, apply the patch, create a report with an SQL error and run it. Confirm that the 'Return to previous page' link works as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16281 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50585|0 |1 is obsolete| | Attachment #50589|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50603&action=edit [PASSED QA] Bug 16281: Remove the use of 'onclick' from Reports module EDIT: Removing unnecessary functions To test: 1) Go to Reports -> Dictionary a) Attempt to delete a definition. Confirm the Ok and cancel buttons in confirm dialog work as expected 2) Go to Reports -> Build new a) On each step of building a report, confirm the back button works as expected b) Confirm add column and delete column on step 3 works as expected 3) Confirm deleting a report from the toolbar triggers confirm dialog and it works as expected 4) Create a report with an SQL error and run it. Confirm that the 'Return to previous page' link works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16281 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Should be in the May 2016 release! Merci Aleisha! -- You are receiving this mail because: You are watching all bug changes.