https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141065&action=edit Bug 28396: Add dataTable to cn_browser To test: 1. Have a bunch of similar or exactly the same call numbers. I updated all mine to '123abc'. 2. Set up the cn_browser.pl plugin for some frameworks, I am usiong the default one. 3. Go to '/cgi-bin/koha/cataloguing/plugin_launcher.pl?q=123abc&plugin_name=cn_browser.pl' and search for the call number '123abc'. 4. You will see 15 results and have no way of seeing any more. 5. Apply patch, restart_all 6. Perform the search again. You should see all your results in a paginated dataTable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Donna <bwsdonna@gmail.com> --- Works as expected, helpful addition!!! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Something is not quite right here for me. As we have no callnumbers in the sample data, I copied the itemnumber into itemcallnumber, set cn_source to z (generic) and ran touch_all_items so set cn_sort. For me the main purpose of the callnumber browser is to quickly determine if a callnumber has already been used. If it's used, you have a red line, if it's free, you see a green line where the callnumber would be. 1) Existing: Search for 26 Old: You get the red markup for 26. 26 shows between 259 and 260 as expected. New: Same. OK. 2) Not existing: Search for 1000 Old: Green line between 100 and 101 as expected. New: You see the green line on top of the table, before 1, you are no longer seeing the "before and after" correctly. Not OK. 3) Existing, not on first page: Search for 500 Old: You get the red markup for 500. 500 shows between 50 and 501 as expected. New: You see the page with the first numbers, no clue red or green as the number is on a much later page. You can page there... (not nice) or you can use the table search - more clicks and you don't see the before and after. Not OK. 2) Modal For me the window is a bit too small now and the table doesn't resize properly when the window size is increased (maybe side effects of the new staff design?) 3) Sorting cn_sort should be used for sorting on the call number column. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Perhaps making this into a dataTable is not a good idea. Maybe instead we can either up the number of results shown at a time. Or maybe a system preference so the number of results can be defined there? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.