[Bug 28452] New: Add managing librarian to transaction page (boraccount.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Bug ID: 28452 Summary: Add managing librarian to transaction page (boraccount.pl) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Some librarians would fine it handy if they could see which librarian managed (accepted a payment, wrote off a fine, etc ) a give transaction. It would be nice if there was a 'Managed by' column in the account-fines table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121390&action=edit Bug 28452: add Managed by column to boraccount.tt To test: -Do some transactions on boraccount.tt. Payments, write-offs.. -Check the transaction tab at boraccount.tt -No info about the librian who did this action -Apply patch -Try doing some more transactions -You should now see the first and last name of the librarian who accepted the payments/did the transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121390|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121391&action=edit Bug 28452: add Managed by column to boraccount.tt To test: -Do some transactions on boraccount.tt. Payments, write-offs.. -Check the transaction tab at boraccount.tt -No info about the librian who did this action -Apply patch -Try doing some more transactions -You should now see the first and last name of the librarian who accepted the payments/did the transactions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- Tested on the ByWater sandboxes. Nice enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121568&action=edit Bug 28452: Add Managed by column to boraccount.tt To test: -Do some transactions on boraccount.tt. Payments, write-offs.. -Check the transaction tab at boraccount.tt -No info about the librian who did this action -Apply patch -Try doing some more transactions -You should now see the first and last name of the librarian who accepted the payments/did the transactions Signed-off-by: George Williams (NEKLS) <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121569&action=edit Bug 28452: (QA follow-up) Remove comma when staff user has on firstname Also removed an old outdated comment line - there are no longer any hardcoded $ signs in the template. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121391|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Lucas, after I thought this was working, there are issues: - Have you tested with another user, not the one who did the transaction? I think using the logged in user here will always make the same name appear instead of the actual user who did the transaction. You need to access the information for the line from the database. - patron-title.inc must be used for displaying the name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed, the table will always show the logged in user for ALL transactions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org