[Bug 13144] New: Google transliteration does not work on bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Bug ID: 13144 Summary: Google transliteration does not work on bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org Google transliteration does not work on bootstrap -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com, | |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #1 from Amit <amitddng135@gmail.com> --- Created attachment 33202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33202&action=edit Bug 13144 - Google transliteration does not work on bootstrap There was no id defined for that particular element to identify it. To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. Follow patch: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07a... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33220&action=edit Bug 13144: Google transliteration does not work on bootstrap To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07a... Signed-off-by: Frederic Demians <f.demians@tamil.fr> I had been able to reproduce the bug (a regression), and I can confirm that this patch fix it. But I had to create manualy GoogleIndicTransliteration system preference, which doesn't exist in standard .pref file. It may be necessary to add it. In my opinion, it shouldn't prevent to include this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this should not stay an undocumented feature. At least the preference should not have to be manually added but be a part of the sys pref editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13206 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33220|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33272&action=edit [PASSED QA] Bug 13144: Google transliteration does not work on bootstrap To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07a... Signed-off-by: Frederic Demians <f.demians@tamil.fr> I had been able to reproduce the bug (a regression), and I can confirm that this patch fix it. But I had to create manualy GoogleIndicTransliteration system preference, which doesn't exist in standard .pref file. It may be necessary to add it. In my opinion, it shouldn't prevent to include this patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a somewhat 'hidden' feature, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #5 from Amit <amitddng135@gmail.com> --- Hi Katrin, Thanks will create Google Transliteration as a system preference. Please see Bug: 13211 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #6 from Amit <amitddng135@gmail.com> --- Hi Katrin, I have created the patch Bug: 13211. Please test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13211 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |13211 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33301&action=edit Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Apply patches on bug 13144 7. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33301|0 |1 is obsolete| | CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #7)
Created attachment 33301 [details] [review] Bug-13211: Added Google Indic Transliteration as a System Preference
Sorry for the blip. git bz thought it should attach here, because I applied 13144 in order to test 13211. I believe the status was passed QA before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13144 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Amit! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org