[Bug 13194] New: Tiny typo in POD for SetMessagingPreferencesFromDefaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Bug ID: 13194 Summary: Tiny typo in POD for SetMessagingPreferencesFromDefaults Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org The POD for C4::Members::Messaging::SetMessagingPreferencesFromDefaults() has an example of usage: C4::Members::Messaging::SetMessagingPreferenceFromDefaults( { borrowernumber => $borrower->{'borrowernumber'} categorycode => 'CPL' } ); The name of the subroutine is mis-spelled as SetMessagingPreferenceFromDefaults when it should be SetMessagingPreference*s*FromDefaults. This has no practical consequences of course, but if you copy and paste the example into your code it can lead to some unnecessary head scratching. Trust me, I know... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 33195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33195&action=edit Fix typo in SetMessagingPreferencesFromDefaults POD The example usage for C4::Members::Messaging::SetMessagingPreferencesFromDefaults calls the subroutine SetMessagingPreferenceFromDefaults, not SetMessagingPreferencesFromDefaults (missing the 's' at the end of 'Preferences'). To test: - Apply the patch - Check that the POD now refers to the actual name of the subroutine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33195|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33221&action=edit [SIGNED OFF] Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD The example usage for C4::Members::Messaging::SetMessagingPreferencesFromDefaults calls the subroutine SetMessagingPreferenceFromDefaults, not SetMessagingPreferencesFromDefaults (missing the 's' at the end of 'Preferences'). To test: - Apply the patch - Check that the POD now refers to the actual name of the subroutine (perldoc C4::Members::Messaging) http://bugs.koha-community.org/show_bug.cgi?id=13194 Adding 's' is the correct doc change to make it match with the function definition. Comfirmable with less. perldoc C4::Members::Messaging proves the doc is still nice. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33221|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33250&action=edit Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD The example usage for C4::Members::Messaging::SetMessagingPreferencesFromDefaults calls the subroutine SetMessagingPreferenceFromDefaults, not SetMessagingPreferencesFromDefaults (missing the 's' at the end of 'Preferences'). To test: - Apply the patch - Check that the POD now refers to the actual name of the subroutine (perldoc C4::Members::Messaging) Adding 's' is the correct doc change to make it match with the function definition. Comfirmable with less. perldoc C4::Members::Messaging proves the doc is still nice. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13194 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org