[Bug 31698] New: Add ability to move a hold to a new biblio/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Bug ID: 31698 Summary: Add ability to move a hold to a new biblio/item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Sometimes a library gets a new edition, or a new copy of an item and would like to be able to directly provide this to a patron with an existing hold. We propose add a new action on the holds table on request.pl 'Move hold' For an item level hold it would provide a modal with a barcode entry box so librarians can scan a new copy in hand, and move the hold to that specific item For a biblio level hold it would provide a modal with a search box - entering keywords would search the catalog, and add a 'Move hold' button to the results - similar to 'Add to basket form existing record' search in acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lisette Scheer <lisettepalouse+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisettepalouse+koha@gmail.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #1 from Kristi <kkrueger@cuyahogalibrary.org> --- We would love to see this capability! It would be ideal if moving all holds on the bib at once were built in. This would be helpful for bibs with many (over 50) holds on them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Felicity Brown <felicity.brown@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown@montgomeryco | |untymd.gov --- Comment #2 from Felicity Brown <felicity.brown@montgomerycountymd.gov> --- This would be a fantastic solution to a problem we've been having with re-orders of older titles, where we get the newer edition as a replacement. Our current workaround creates some pretty yucky metadata. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #3 from Kristi <kkrueger@cuyahogalibrary.org> --- (In reply to Felicity Brown from comment #2)
This would be a fantastic solution to a problem we've been having with re-orders of older titles, where we get the newer edition as a replacement. Our current workaround creates some pretty yucky metadata.
Same for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Rhonda Kuiper <rkuiper@roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov --- Comment #4 from Rhonda Kuiper <rkuiper@roundrocktexas.gov> --- This function would be fantastic for our library. Currently, our processes to move holds is time consuming and prone to errors. This would be great! One thing to specifically note is that the date that the hold was placed on the original item would be preserved. This was the order of the holds queue could be preserved and sorted in the the holds on the new item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Piia Semenoff <piia.semenoff@ouka.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piia.semenoff@ouka.fi --- Comment #5 from Piia Semenoff <piia.semenoff@ouka.fi> --- This sounds good! I totally agree that currently the transfer of the holds takes time and the possibility of errors is high. I think these are the things that can go wrong now while doing the hold transfer and should be considered when building this function: - It should be taken into account whether the hold has been suspended or whether it is a itemlevel hold or a non-urgent hold. - In addition, you must choose the right pick-up location for the hold, change the hold date and priority of the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://bywatersolutions.co | |m/crowdsourcing/move-hold Change sponsored?|--- |Seeking sponsor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Ilona R <hattara@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hattara@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 olivier.delangle@univ-amu.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivier.delangle@univ-amu.f | |r --- Comment #6 from olivier.delangle@univ-amu.fr --- I agree. We are facing the same situation. A new action on the holds table on request.pl 'Move hold' would be very helpful -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Katariina Pohto <katariina.pohto@ouka.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.pohto@ouka.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179226&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179235&action=edit Bug 31698: Add new move_hold_item subroutine to Hold.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179236&action=edit Bug 31698: Implement move_hold_item in request.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179279&action=edit Bug 31698: Make move_hold_item use CanItemBeReserved and add logging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179287&action=edit Bug 31698: Template and javascript changes to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179290&action=edit Bug 31698: Report errors and failures back to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179291&action=edit Bug 31698: Deal with priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179292&action=edit Bug 31698: Improve priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179295&action=edit Bug 31698: Flip the logic for priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Iina Niemi <iina.niemi@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iina.niemi@turku.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179704&action=edit Bug 31698: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179711&action=edit Bug 31698: Use _ShiftPriority to deal with priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179713&action=edit Bug 31698: Call _FixPriority on orginal biblio to clean-up priorty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179295|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179713|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179226|0 |1 is obsolete| | --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181222&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179235|0 |1 is obsolete| | --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181223&action=edit Bug 31698: Add new move_hold_item subroutine to Hold.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181224&action=edit Bug 31698: Template and javascript changes to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181225&action=edit Bug 31698: Report errors and failures back to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179704|0 |1 is obsolete| | --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181226&action=edit Bug 31698: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181222|0 |1 is obsolete| | --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181228&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181229&action=edit Bug 31698: Add new move_hold_item subroutine to Hold.pm and request.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181224|0 |1 is obsolete| | --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181230&action=edit Bug 31698: Template and javascript changes to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181225|0 |1 is obsolete| | --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181231&action=edit Bug 31698: Report errors and failures back to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181232&action=edit Bug 31698: Add support for moving record level holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181233&action=edit Bug 31698: Combine item and record level subroutines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181229|0 |1 is obsolete| | Attachment #181230|0 |1 is obsolete| | Attachment #181231|0 |1 is obsolete| | Attachment #181232|0 |1 is obsolete| | Attachment #181233|0 |1 is obsolete| | --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181234&action=edit Bug 31698: Add ability to move holds to new items or new records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181929&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181930&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181228|0 |1 is obsolete| | --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181944&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181234|0 |1 is obsolete| | --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181945&action=edit Bug 31698: Add ability to move holds to new items or new records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181929|0 |1 is obsolete| | --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181946&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181930|0 |1 is obsolete| | --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181947&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181948&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181944|0 |1 is obsolete| | --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181951&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181945|0 |1 is obsolete| | --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181952&action=edit Bug 31698: Add ability to move holds to new items or new records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181946|0 |1 is obsolete| | --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181953&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181947|0 |1 is obsolete| | --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181954&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181948|0 |1 is obsolete| | --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181955&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181956&action=edit Bug 31698: Disallow moving waiting or intransit holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181951|0 |1 is obsolete| | --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181957&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181952|0 |1 is obsolete| | --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181958&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181953|0 |1 is obsolete| | --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181959&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181954|0 |1 is obsolete| | --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181960&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181955|0 |1 is obsolete| | --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181961&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181956|0 |1 is obsolete| | --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181962&action=edit Bug 31698: Disallow moving waiting or intransit holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking sponsor |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to move a hold |Add ability to move a hold |to a new biblio/item |to a new bibliographic | |record/item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181962|0 |1 is obsolete| | --- Comment #50 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 182639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182639&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #51 from Kristi <kkrueger@cuyahogalibrary.org> --- Re: Step 25, I do see in the hold log a modify entry. For example, if I created a hold on bib 20, and I move it to bib 8, the log shows the create entry with 'biblionumber'=20 and the modify entry with 'biblionumber=8 for the same object number. Re: Step 26, I think this was supposed to be set AllowHoldsOnDamagedItems to "don't allow" If this is correct, then the error message shows as expected (see attached screenshot). If it is indeed supposed to be a turn on, that is Allow for this system preference, there is no error message. One final thing, sometimes on moving record level holds, it shows the checkbox/"Move all selected record level holds..." message twice (see attached RecordLevel_ListTwice.PNG) I didn't think this was big enough not to sign off, but I wanted to call it out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #52 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 182640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182640&action=edit Error Message for Don't allow holds on damaged items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #53 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 182641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182641&action=edit Checkbox for record level moves sometimes shows twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #54 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Bug 23269 is going to conflict with this one, I'll need to rebase this on top of that one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23269 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23269 --- Comment #55 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #54)
Bug 23269 is going to conflict with this one, I'll need to rebase this on top of that one.
Well, maybe not. Bug 23269 has some problems and I don't want to wait. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23269 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |*** Sponsored by Cuyahoga release notes| |County Public Library *** CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184750&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #57 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Re: Step 26, I think this was supposed to be set AllowHoldsOnDamagedItems to "don't allow" If this is correct, then the error message shows as expected (see attached screenshot). If it is indeed supposed to be a turn on, that is Allow for this system preference, there is no error message. Yes, this is a mistake in the test plan.
One final thing, sometimes on moving record level holds, it shows the checkbox/"Move all selected record level holds..." message twice (see attached RecordLevel_ListTwice.PNG) I didn't think this was big enough not to sign off, but I wanted to call it out. I have added a patch that should fix this problem.
Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k CC| |pedro.amorim@openfifth.co.u | |k Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #58 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185050&action=edit Bug 31698: Adjust number of tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181957|0 |1 is obsolete| | --- Comment #59 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185064&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181958|0 |1 is obsolete| | --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185065&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181959|0 |1 is obsolete| | --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185066&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181960|0 |1 is obsolete| | --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185067&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181961|0 |1 is obsolete| | --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185068&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182639|0 |1 is obsolete| | --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185069&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184750|0 |1 is obsolete| | --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185070&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hey all, nice feature! From my testing everything appears to be working nicely, but I have some comments: A) Step 6: The 'Move selected (0)' button is not disabled. It's styled differently to the 'Cancel selected (0)' button. It still expands options when clicked even if no holds are selected. My suggestion would be to style it the same as 'Cancel selected (0)' and not expand options if no holds are selected. Ideally using the 'disabled' CSS class but may be out of scope (?). B) Step 13: If you enter a partial barcode like '76', 20 hits are returned (I believe only limited by the default paging of 20 from the REST API). I don't know if this needs addressing or not, but I wonder if an exact match for barcode here makes more sense. C) Step 15: Clicking 'Move all selected item level holds to this item' does enable the 'Move selected holds' button and the checkbox column under the 'Review holds to move' is ticked by default. If you untick the latter, and keep the top 'Move all...' checkbox ticked, then click 'Move selected holds', the page redirects as if something happened, but no holds were moved (because none were selected, in the modal). My suggestion would be to have this button disabled if no 'holds to move' are ticked. D) Step 17: After moving the hold(s), it's nice that a message is shown 'Moved from X to Y', but the URL becomes '/cgi-bin/koha/reserve/request.pl'. This causes clicks on any of the links on the left side menu to result on a 404 (or 500) errors. My suggestion would be to have this URL '/cgi-bin/koha/reserve/request.pl?biblionumber=X' with the original record's biblionumber (the 'moved from' record). E) Step 19: Moving record level holds, the modal says 'Enter the biblionumber of new hold target', but if you enter 'xyz' and then search, the error shown is 'No item found with barcode: xyz'. This error message should refer to the biblionumber e.g. 'Biblionumber 'xyz' not found.' I think these are all very minor, with the exception perhaps of D) that I'd consider a bit more of a blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #67 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185121&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #68 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Lucas I added a follow-up that implements your last patch differently, querying the biblios endpoint directly instead of using the items endpoint and then filtering on the client side. I've tested it myself to ensure it works, of course, but if my patch introduces issues or it's not worth it please feel free to obsolete! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185379&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185380&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185064|0 |1 is obsolete| | --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185607&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185065|0 |1 is obsolete| | --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185608&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185066|0 |1 is obsolete| | --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185609&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185067|0 |1 is obsolete| | --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185610&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185068|0 |1 is obsolete| | --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185611&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185069|0 |1 is obsolete| | --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185612&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185070|0 |1 is obsolete| | --- Comment #77 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185613&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185121|0 |1 is obsolete| | --- Comment #78 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185614&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185379|0 |1 is obsolete| | --- Comment #79 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185615&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185380|0 |1 is obsolete| | --- Comment #80 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185616&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185607|0 |1 is obsolete| | --- Comment #81 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185753&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185608|0 |1 is obsolete| | --- Comment #82 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185754&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185609|0 |1 is obsolete| | --- Comment #83 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185755&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185610|0 |1 is obsolete| | --- Comment #84 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185756&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185611|0 |1 is obsolete| | --- Comment #85 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185757&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185612|0 |1 is obsolete| | --- Comment #86 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185758&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185613|0 |1 is obsolete| | --- Comment #87 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185759&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185614|0 |1 is obsolete| | --- Comment #88 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185760&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185615|0 |1 is obsolete| | --- Comment #89 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185761&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185616|0 |1 is obsolete| | --- Comment #90 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185762&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #91 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185763&action=edit Bug 31698: Move request.tt JS to hold.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179290|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #92 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185764&action=edit Bug 31698: Report errors and failures back to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185753|0 |1 is obsolete| | --- Comment #93 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185765&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185754|0 |1 is obsolete| | --- Comment #94 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185766&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185755|0 |1 is obsolete| | --- Comment #95 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185767&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185756|0 |1 is obsolete| | --- Comment #96 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185768&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185757|0 |1 is obsolete| | --- Comment #97 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185769&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185758|0 |1 is obsolete| | --- Comment #98 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185770&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185759|0 |1 is obsolete| | --- Comment #99 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185771&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185760|0 |1 is obsolete| | --- Comment #100 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185772&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185761|0 |1 is obsolete| | --- Comment #101 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185773&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185762|0 |1 is obsolete| | --- Comment #102 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185774&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185764|0 |1 is obsolete| | --- Comment #103 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185775&action=edit Bug 31698: Report errors and failures back to request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185763|0 |1 is obsolete| | --- Comment #104 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185776&action=edit Bug 31698: Move request.tt JS to hold.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #105 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185834&action=edit Bug 31698: Move reamining JS to hold.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185765|0 |1 is obsolete| | --- Comment #106 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186085&action=edit Bug 31698: Add alter_hold_targets permission Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185766|0 |1 is obsolete| | --- Comment #107 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186086&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185767|0 |1 is obsolete| | --- Comment #108 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186087&action=edit Bug 31698: Fix modals for item level moves Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185768|0 |1 is obsolete| | --- Comment #109 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186088&action=edit Bug 31698: Fix modals for biblio level moves Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185769|0 |1 is obsolete| | --- Comment #110 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186089&action=edit Bug 31698: Add unit tests Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185770|0 |1 is obsolete| | --- Comment #111 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186090&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi <kkrueger@cuyahogalibrary.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185771|0 |1 is obsolete| | --- Comment #112 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186091&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185772|0 |1 is obsolete| | --- Comment #113 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186092&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185773|0 |1 is obsolete| | --- Comment #114 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186093&action=edit Bug 31698: Style move selected button and disable when nothing is selected Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185774|0 |1 is obsolete| | --- Comment #115 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186094&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185775|0 |1 is obsolete| | --- Comment #116 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186095&action=edit Bug 31698: Report errors and failures back to request.tt Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185776|0 |1 is obsolete| | --- Comment #117 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186096&action=edit Bug 31698: Move request.tt JS to hold.js Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185834|0 |1 is obsolete| | --- Comment #118 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186097&action=edit Bug 31698: Move reamining JS to hold.js Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #119 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186098&action=edit Bug 31698: (QA follow-up): Prevent display 'NaN' UI error message If the input is not a number, display an appropriate error message. Additionally, don't make an API call unless the input is a number. Test by doing the following: 1) Step 19: Moving record level holds, the modal says 'Enter the biblionumber of new hold target', but if you enter 'xyz' and then search, the error shown is 'No item found with barcode: NaN'. This patch fixes that. Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #120 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi Lucas: 1) I've added a follow-up. Please check if you agree. 2) Passing QA as all my observations were addressed (thank you!) and QA script is happy, however 3) Can you please ensure that all the new code in holds.js is translatable e.g.: $("#itemResultMessage").html(` <div class="alert alert-warning">No item found with barcode: ${externalID}.</div> ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #121 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186105&action=edit Bug 31698: Make strings in holds.js translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #122 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #120)
Hi Lucas: 1) I've added a follow-up. Please check if you agree. 2) Passing QA as all my observations were addressed (thank you!) and QA script is happy, however 3) Can you please ensure that all the new code in holds.js is translatable e.g.:
$("#itemResultMessage").html(` <div class="alert alert-warning">No item found with barcode: ${externalID}.</div> );
I agree with your follow-up, thanks! I have also supplied a follow to make the string translatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186105|0 |1 is obsolete| | --- Comment #123 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186115&action=edit Bug 31698: Make strings in holds.js translatable Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #124 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186247&action=edit Bug 31698: Add alter_hold_targets to t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #125 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #126 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- This is great news! So happy to see this. Any chance for backports on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|*** Sponsored by Cuyahoga |This enhancement allows for release notes|County Public Library *** |staff to move item level | |holds to new items and | |record level holds to new | |records. From the holds | |list page ( | |reserve/request.pl ) staff | |will now see the option to | |"Move selected holds" if | |they have the | |alter_hold_target | |permission. When the button | |is clicked a modal will be | |presented allowing staff to | |choose a new record target | |for record level holds or a | |new item target for item | |level holds. | | | |This patch also adds the | |new permission that is | |required to move holds, | |alter_hold_target. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41124 [Bug 41124] Add search options for moving hold to new biblio record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #127 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- We'd be interested about the possibility of backporting this to 25.05 too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #128 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Anneli Österman from comment #127)
We'd be interested about the possibility of backporting this to 25.05 too.
New features should not be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com Comma delimited| |Cuyahoga County Public list of Sponsors| |Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows for |This enhancement allows for release notes|staff to move item level |staff to move item level |holds to new items and |holds to new items and |record level holds to new |record level holds to new |records. From the holds |records. From the holds |list page ( |list page ( |reserve/request.pl ) staff |reserve/request.pl ) staff |will now see the option to |will now see the option to |"Move selected holds" if |"Move selected holds" if |they have the |they have the |alter_hold_target |alter_hold_target |permission. When the button |permission. When the button |is clicked a modal will be |is clicked a modal will be |presented allowing staff to |presented allowing staff to |choose a new record target |choose a new record target |for record level holds or a |for record level holds or a |new item target for item |new item target for item |level holds. |level holds. | | |This patch also adds the |This patch also adds the |new permission that is |new permission that is |required to move holds, |required to move holds, |alter_hold_target. |alter_hold_target. | | | |Sponsored by: Cuyahoga | |County Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Kimberly <kimberly.diebolt@edcgov.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kimberly.diebolt@edcgov.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41727 [Bug 41727] When moving a hold to a new biblio, allow selection of biblio via item barcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41879 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41880 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 [Bug 41880] Logs for moved holds don't indicate original bib number/item number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42429 [Bug 42429] Order of moving holds between bibs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 [Bug 42524] Option to calculate priorities based on reservedate when moving hold to a new record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|clackman@fargolibrary.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42722 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org