[Bug 39485] New: opac-export: Wide character in print at opac-export.pl line 191
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Bug ID: 39485 Summary: opac-export: Wide character in print at opac-export.pl line 191 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org
From a 23.11 log (lineno different) [2025/03/16 21:11:18] [WARN] Wide character in print at /usr/share/koha/opac/opac-export.pl line 189.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179914&action=edit Bug 39485: Fix wide character in print-warn in opac-export Similar change in intranet counterpart: catalogue/export. Test plan: Verify no warning anymore when using ris or isbd when record contains specific Unicode character(s). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179914|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180078&action=edit Bug 39485: Fix wide character in print-warn in opac-export Similar change in intranet counterpart: catalogue/export. Test plan: Verify no warning anymore when using ris or isbd when record contains specific Unicode character(s). Signed-off-by: Magnus Enger <magnus@libriotech.no> I could not trigger "Wide character" for RIS in the OPAC, but for ISBD I can see it removes that warning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I'll look at QAing this shortly. At a glance, this change makes a lot of sense, but I'll double-check everything. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Testing on main branch in ktd with a payload of "Türkiye 我爱你" in the MARC 100$a field *before applying the patch*: OPAC: I get the "Wide characters in print" only for "ISBD" [2025/04/22 02:06:56] [WARN] Wide character in print at /kohadevbox/koha/opac/opac-export.pl line 191. Staff: I see it for "BIBTEXT", "all Dublin core options", "MODS" [2025/04/22 02:09:40] [WARN] Wide character in print at /kohadevbox/koha/catalogue/export.pl line 80. NOTE: Even when I saw "Wide characters in print", the output itself seemed good. -- Same test *after applying the patch* and restarting Koha plack workers. OPAC: Can't generate the error. All the output looks good except MARC-8 (but that appears to be unrelated to this change and I think just has to do with MARC-8 not being great with Chinese?). Staff: Can't generate the error. All the output looks good except MARC-8 (but that appears to be unrelated to this change and I think just has to do with MARC-8 not being great with Chinese?). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- The existing export code invokes some "interesting" functions from C4/Record.pm and other places... I have a Koha plugin where I export ISO MARC and the other day I found I had to run C4::Charset::SetUTF8Flag( $marc, 1 ); on the MARC::Record object before using MARC::Record->as_usmarc even though I was printing to a filehandle that I'd opened using ":encoding(UTF-8)", so that was weird. Without that function call, it wasn't exporting the text "Türkiye" correctly. I think that's just a quirk of MARC::File::USMARC though. -- Anyway... this code removes the warning and all the output looks good, so I'm going to pass it. In theory, "binmode STDOUT, ':encoding(UTF-8)'" should be enough to tell Perl that we're outputting UTF-8 encoded bytes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-export: Wide character |"Wide character in print" |in print at opac-export.pl |when exporting from staff |line 191 |interface and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180078|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 181236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181236&action=edit Bug 39485: Fix wide character in print-warn in opac-export Similar change in intranet counterpart: catalogue/export. Test plan: Verify no warning anymore when using ris or isbd when record contains specific Unicode character(s). Signed-off-by: Magnus Enger <magnus@libriotech.no> I could not trigger "Wide character" for RIS in the OPAC, but for ISBD I can see it removes that warning. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39485 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Big fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org