[Bug 26852] New: Subfield $e missing in X11 definition of MARC 21 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Bug ID: 26852 Summary: Subfield $e missing in X11 definition of MARC 21 headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org According to MARC 21 definition, subfield $e should be controlled by authority records in X11 fields. Cf.: http://www.loc.gov/marc/authority/ad111.html http://www.loc.gov/marc/authority/adx11.html http://www.loc.gov/marc/bibliographic/bdx11.html Currently, $e is missing in X11 field description in C4/Heading/MARC21.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |januszop@gmail.com Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 112654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112654&action=edit Bug 26852 -- subfield $e missing in X11 definition of MARC21 headings Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- e is almost certainly missing because in x00 and x10 it's the Relator term, which shouldn't be included, so you should also remove j from x11, so a heading with a j will link correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #3 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Phil Ringnalda from comment #2)
e is almost certainly missing because in x00 and x10 it's the Relator term, which shouldn't be included, so you should also remove j from x11, so a heading with a j will link correctly.
Yes, you are right. I missed the $j which should be removed from X11 controlled subfields list (as it contains the relator term). A corrected version of the patch follows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112654|0 |1 is obsolete| | --- Comment #4 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 120284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120284&action=edit Bug 26852 -- subfield $e missing in X11 definition of MARC21 headings A corrected version of the patch. BTW, it removes $e from the subfields list for 100 and 110 in $auth_heading_fields, introduced (by mistake?) by patch 21958 (which was rather wrong - $e should not be controlled by authority record in X00 and X10 fields, as it contains a relator term). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 S. Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #5 from S. Brown <sbrown@bywatersolutions.com> --- I followed this and it worked as intended - sign-off through sandbox didn't work properly so am signing off here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123665&action=edit Bug 26852: subfield $e missing in X11 definition of MARC21 headings This patch adds $e to 111 and 611, but removes it from 100 and 110 as it's used for the relator term there and should not be copied. Same for 111$j. Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. Repeat testing in similar fashion for authorities: 9. 100/110 $e 10. 111 $j NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml Signed-off-by: S. Brown <sbrown@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subfield $e missing in X11 |Add missing X11$e and |definition of MARC 21 |remove relator term |headings |subfields from MARC21 | |headings --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've added a sign-off line for "S. Brown" manually using the email address from the bugzilla account. Also amended the test plan and commit message a bit to reflect the additional fixes for $e/$j relator terms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Attachment #120284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123665|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123780&action=edit Bug 26852: subfield $e missing in X11 definition of MARC21 headings This patch adds $e to 111 and 611, but removes it from 100 and 110 as it's used for the relator term there and should not be copied. Same for 111$j. Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. Repeat testing in similar fashion for authorities: 9. 100/110 $e 10. 111 $j NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml Signed-off-by: Sara Brown <sbrown@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #7)
I've added a sign-off line for "S. Brown" manually using the email address from the bugzilla account.
First name adjusted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123852&action=edit Bug 26852: Fix Heading.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #12)
Created attachment 123852 [details] [review] Bug 26852: Fix Heading.t
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Bug 21958 as impacted C4::Heading::MARC21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21958 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.10 Note that 20.11 does not contain Bug 21958 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This patch adds $e to 111 release notes| |and 611, but removes it | |from 100 and 110 as it's | |used for the relator term | |there and should not be | |copied. Same for 111$j. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org