https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27610, 27740, 27876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 [Bug 27610] Accessibility: OPAC - <h1> on each page is Logo but should be page description/title https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 [Bug 27876] Accessibility: OPAC - Reduce heading redundancy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Created attachment 121140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121140&action=edit Bug 28242: added captions to tables and legends to forms Ensured that in the OPAC, all tables have relevant captions and all forms have relevant legends. Many of these have class="sr-only" so they are not visible but will be available for people who use screen-readers. To test: 1) Go to OPAC 2) Apply patch and dependencies 3) Check that on all pages, any tables have a caption (many of them will not be visible, but will be in the markup code) 4) Check that on all pages, any forms have a legend (many of them will not be visible, but will be in the markup code) 5) Check that the captions are appropriate and relevant 6) Check that the legends are appropriate and relevant Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This is a very nice improvement to overall OPAC accessibility. I checked the following templates and, to me, everything looks good: clubs/clubs-tab.tt clubs/enroll.tt opac-MARCdetail.tt opac-authoritiessearchresultlist.tt opac-basket.tt opac-browse.tt opac-browser.tt opac-course-details.tt opac-course-reserves.tt opac-detail.tt opac-downloadshelf.tt opac-full-serial-issues.tt opac-holdshistory.tt opac-idref.tt opac-illrequests.tt opac-issue-note.tt opac-main.tt opac-messaging.tt opac-passwd.tt opac-password-recovery.tt opac-patron-consent.tt opac-privacy.tt opac-readingrecord.tt opac-reportproblem.tt opac-request-article.tt opac-reserve.tt opac-results.tt opac-review.tt opac-routing-lists.tt opac-search-history.tt opac-sendbasketform.tt opac-sendshelfform.tt opac-serial-issues.tt opac-shareshelf.tt opac-shelves.tt opac-showreviews.tt opac-suggestions.tt opac-user.tt sci/sci-main.tt sco/sco-main.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 --- Comment #5 from wainuiwitikapark@catalyst.net.nz --- (In reply to Tomás Cohen Arazi from comment #4)

I'm not familiar with accessibility guidelines, but understand this changes. I would like to know if this is on purpose. In this case, the <h2> tag is removed in the resulting caption:

- <div id="opac-user-fines"> <h2>Credits</h2> + <div id="opac-user-fines"> <table class="table table-bordered table-striped"> + <caption>Credits</caption>

but in some others it is kept:

- <h2>Results</h2> <table id="sci_bcheckins_table" class="table table-bordered table-striped dataTable no-footer"> + <caption><h2>Results</h2></caption>

Maybe there's a reason, but I would like it commented on the commit message, unless it needs to be fixed for consistency.

Great work BTW!

Hi Tomás, Thank you for your comment! Yes I understand this is quite confusing. Basically Koha is set up without a lot of accessibility in mind and there is a lot of inconsistency. Therefore, I sort of just chose to do things on a case by case basis and sometimes it is unnecessary to have headings, and sometimes it makes sense to have both captions and headings. I will make a point to try and document these decisions more. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121924&action=edit Bug 28242: added captions to tables and legends to forms Ensured that in the OPAC, all tables have relevant captions and all forms have relevant legends. Many of these have class="sr-only" so they are not visible but will be available for people who use screen-readers. To test: 1) Go to OPAC 2) Apply patch and dependencies 3) Check that on all pages, any tables have a caption (many of them will not be visible, but will be in the markup code) 4) Check that on all pages, any forms have a legend (many of them will not be visible, but will be in the markup code) 5) Check that the captions are appropriate and relevant 6) Check that the legends are appropriate and relevant Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Considering this a bug for the sake of accessibility. Backported to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |As part of improving OPAC release notes| |accessibility this change | |ensures that all tables | |have relevant captions and | |all forms have relevant | |legends - this makes | |navigation easier for | |people using a screen | |reader. | | | |Note: Many of the | |captions and legends have | |class="sr-only" so they are | |not visible, but are | |available for people who | |use a screen reader. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.