[Bug 24616] New: Cannot copy notice to another branch if it already exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Bug ID: 24616 Summary: Cannot copy notice to another branch if it already exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org If you try to copy a notice or slip to another branch and that branch already has that notice or slip, it will not let you save it. There needs to be a way to overwrite the existing notice or slip without having to delete first then copy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- We are facing this same problem. I guess one possible solution could be move to "Modify notice" page instead "Add notice" if notice already exists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 138242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138242&action=edit Bug 24616: Allow copying notice to a branch even if it exists in that branch If you try to copy notice or slip to a branch which already has that notice or slip Koha won't let you save it. Instead pop-up saying branch already has that notice is displayed. This patch allows users to copy and override already existing notice or slip. To test: 1. Find notice which exists e.g. in all branches and branch A. 2. Copy that notice, add notice screen is displayed. 3. Press save. => Pop-up informing that notice already exists in branch A is displayed. 4. Apply this patch. 5. Repeat steps 2. and 3. => Notice is saved succesfully. Also try to save the notice you tested with as a new (same code) to branch A. Confirm that pop-up is displayed as it should be. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #1)
We are facing this same problem. I guess one possible solution could be move to "Modify notice" page instead "Add notice" if notice already exists.
This wasn't the solution, but I still think we should move to "Modify notice" page in these cases. However I was unsure if this is in scope of this bug or should I open a separete bug report for this (if it doesn't already exists). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- It works, but I don't think this is a complete solution. It needs to warn you that you are overwriting an existing notice or slip and give you the option to proceed or cancel. This is too dangerous as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Christopher Brannon from comment #4)
It works, but I don't think this is a complete solution. It needs to warn you that you are overwriting an existing notice or slip and give you the option to proceed or cancel. This is too dangerous as is.
That's a good point. I'll take a look at this again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138242|0 |1 is obsolete| | --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 138503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138503&action=edit Bug 24616: Allow copying notice to a branch even if it exists in that branch If you try to copy notice or slip to a branch which already has that notice or slip Koha won't let you save it. Instead pop-up saying branch already has that notice is displayed. This patch allows users to copy and override already existing notice or slip. To test: 1. Find notice which exists e.g. in all branches and branch A. 2. Copy that notice, add notice screen is displayed. 3. Press save. => Pop-up informing that notice already exists in branch A is displayed. 4. Apply this patch. 5. Repeat steps 2. and 3. 6. Pop-up to confirm overwrite of notice is displayed. => Confirm that if you press OK, notice is saved succesfully. => Otherwise, changes to notice should not be saved. Also try to save the notice you tested with as a new (same code) to branch A. Confirm that pop-up is displayed as it should be. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138503|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 142672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142672&action=edit Bug 24616: Allow copying notice to a branch even if it exists in that branch If you try to copy notice or slip to a branch which already has that notice or slip Koha won't let you save it. Instead pop-up saying branch already has that notice is displayed. This patch allows users to copy and override already existing notice or slip. To test: 1. Find notice which exists e.g. in all branches and branch A. 2. Copy that notice, add notice screen is displayed. 3. Press save. => Pop-up informing that notice already exists in branch A is displayed. 4. Apply this patch. 5. Repeat steps 2. and 3. 6. Pop-up to confirm overwrite of notice is displayed. => Confirm that if you press OK, notice is saved succesfully. => Otherwise, changes to notice should not be saved. Also try to save the notice you tested with as a new (same code) to branch A. Confirm that pop-up is displayed as it should be. Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Cannot copy notice to |Cannot copy notice to |another branch if it |another library yif it |already exists |already exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Summary|Cannot copy notice to |Cannot copy notice to |another library yif it |another library if it |already exists |already exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but there is a major issue: When I save the changes, I get the overwrite warning, but: if I choose cancel, the changes are still saved. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 142850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142850&action=edit Bug 24616: Do not save form if user press cancel If one starts to copy a notice but then cancels this when pop-up is displayed, changes are still saved. This patch fixes this. To test: 1. Copy notice to a library where it already exists 2. Press save and then cancel when pop-up is displayed => Form and changes are still saved 3. Apply this patch. 4. Repeat steps 1. and 2. => Form is no longer saved Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Changing back to ASSIGNED, latest patch broke saving the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142850|0 |1 is obsolete| | --- Comment #11 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 142856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142856&action=edit Bug 24616: Do not save form if user press cancel If one starts to copy a notice but then cancels this when pop-up is displayed, changes are still saved. This patch fixes this. To test: 1. Copy notice to a library where it already exists 2. Press save and then cancel when pop-up is displayed => Form and changes are still saved 3. Apply this patch. 4. Repeat steps 1. and 2. => Form is no longer saved Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Setting this as Needs Signoff, notice form shouldn't now be saved when pressing cancel on pop-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #13 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- The patch seems to work well. It did warn me of the existing notice and let me save the change anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142856|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145238&action=edit Bug 24616: Do not save form if user press cancel If one starts to copy a notice but then cancels this when pop-up is displayed, changes are still saved. This patch fixes this. To test: 1. Copy notice to a library where it already exists 2. Press save and then cancel when pop-up is displayed => Form and changes are still saved 3. Apply this patch. 4. Repeat steps 1. and 2. => Form is no longer saved Sponsored-by: Koha-Suomi Oy Signed-off-by: ml-inlibro <marie-luce.laflamme@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Signed Off --- Comment #15 from David Nind <david@davidnind.com> --- Changed status to now signed off - see comment #13 and signed off patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142672|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146148&action=edit Bug 24616: Allow copying notice to a branch even if it exists in that branch If you try to copy notice or slip to a branch which already has that notice or slip Koha won't let you save it. Instead pop-up saying branch already has that notice is displayed. This patch allows users to copy and override already existing notice or slip. To test: 1. Find notice which exists e.g. in all branches and branch A. 2. Copy that notice, add notice screen is displayed. 3. Press save. => Pop-up informing that notice already exists in branch A is displayed. 4. Apply this patch. 5. Repeat steps 2. and 3. 6. Pop-up to confirm overwrite of notice is displayed. => Confirm that if you press OK, notice is saved succesfully. => Otherwise, changes to notice should not be saved. Also try to save the notice you tested with as a new (same code) to branch A. Confirm that pop-up is displayed as it should be. Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145238|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146149&action=edit Bug 24616: Do not save form if user press cancel If one starts to copy a notice but then cancels this when pop-up is displayed, changes are still saved. This patch fixes this. To test: 1. Copy notice to a library where it already exists 2. Press save and then cancel when pop-up is displayed => Form and changes are still saved 3. Apply this patch. 4. Repeat steps 1. and 2. => Form is no longer saved Sponsored-by: Koha-Suomi Oy Signed-off-by: ml-inlibro <marie-luce.laflamme@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146150&action=edit Bug 24616: (QA follow-up) Remove "This has bug" comment ... hopefully because there is no more bug now! Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Removed this comment (hopefully rightfully) in a follow-up: +//This has bug 2) return confirm(__("A letter with the code '%s' already exists for '%s'. Overwrite this letter?").format(new_lettercode, new_branchcode)); We get the branchcode in the message instead of the library's name. But: This is already the case for the old error that doesn't allow you to overwrite. So I filed: Bug 32880 - Show library's name instead of branchcode in dialog when overwriting an existing notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |philip.orr@lmscloud.de Resolution|--- |FIXED --- Comment #23 from Philip Orr <philip.orr@lmscloud.de> --- Since the "copy notice" function wasn't in the manual yet, I added some documentation for that. No need for documentation on this bug though since the error message is self-explanatory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org