[Bug 30927] New: Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Bug ID: 30927 Summary: Improve formatting or iCal files for checkout due dates Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. It makes more sense for: A) Checkouts due at midnight to be "All day events" B) Checkouts due at specific time to start in the morning, and end at the time due. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135826&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. It makes more sense for: A) Checkouts due at midnight to be "All day events" B) Checkouts due at specific time to start in the morning, and end at the time due. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout starts in the morning and ends at the due time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I'm getting this error when I click on the iCal link: Can't call method "hour" on an undefined value at /kohadevbox/koha/opac/opac-ics.pl line 88 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135826|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135907&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. It makes more sense for: A) Checkouts due at midnight to be "All day events" B) Checkouts due at specific time to start in the morning, and end at the time due. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout starts in the morning and ends at the due time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #2)
I'm getting this error when I click on the iCal link:
Can't call method "hour" on an undefined value at /kohadevbox/koha/opac/opac-ics.pl line 88
Thanks for testing Owen! I think this new version of the patch should fix that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135910&action=edit Screenshot of how events were added to Calendar on macOS The attached screenshot shows how the iCal entries look in my Calendar app. "The Silver Lotus" is due at 8PM on 2022-06-23. "Up!" is due at no specific time (23:59:59). My calendar thinks the 8PM event spans 24 hours. Google Calendar seems to do the same. I think what we want is for those entries to span no time at all: Starting time at 8PM and ending time at 8PM on the same day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Aaron Sakovich <asakovich@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asakovich@hmcpl.org --- Comment #6 from Aaron Sakovich <asakovich@hmcpl.org> --- RFC 5545 https://datatracker.ietf.org/doc/html/rfc5545 on page 54 (section 3.6.1 Event Component) says the following:
... For cases where a "VEVENT" calendar component specifies a "DTSTART" property with a DATE value type but no "DTEND" nor "DURATION" property, the event's duration is taken to be one day. For cases where a "VEVENT" calendar component specifies a "DTSTART" property with a DATE-TIME value type but no "DTEND" property, the event ends on the same calendar date and time of day specified by the "DTSTART" property.
What if the DTSTART is a DATE or DATE-TIME, and DTEND and DURATION are left blank? We could set it to be a DATE if the due time is 23:59, and a DATE-TIME otherwise. That would result in either an all day event as desired per option A) (when due at midnight) or an event with a specific due time and the end time set to the end of the day, the inverse of Option B) (which might be a more palatable solution as event reminders are typical set based on the start time of an event). Alternatively, a DURATION could be specified in the latter case, but note that DURATION (section 3.8.2.5) is a _positive_ value, and no mention is made in the spec of a zero duration, so I'd be hesitant to reference a zero-value duration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #7 from Aaron Sakovich <asakovich@hmcpl.org> --- Sigh, that didn't take long. My option B is not as I stated -- I misread the spec. Setting no DTEND nor DURATION makes the start and end times coincident, or a zero-duration event. That would be acceptable. Therefore, either pass a DTSTART as a DATE and get an all-day event (option A), or as a DATE-TIME and get a zero-duration event (option B). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135907|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136038&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136038|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136039&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- I think this latest revision satisfies everyone. With it, all items due at midnight will be all day events, and all items due at a specific time will be instantaneous events! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Sorry Kyle, now it's saving all the calendar entries as if they are due at the moment I downloaded the iCal file. All items due at the same minute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136069&action=edit Screenshot from Kyle's testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136070&action=edit ICS file from Kyle's testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #11)
Sorry Kyle, now it's saving all the calendar entries as if they are due at the moment I downloaded the iCal file. All items due at the same minute.
That's odd. What version of Calendar are you using? I'm on Version 11.0 (2811.5.1). Can you take a look at my screen shot and try importing my ICS file? I'm curious if you'll get the same results as me, or the same results as your previous testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Using your ICS file gave me the same result as you show. Here's some new information about my testing, though. Here's the due dates in the account I'm teting: 2022-01-01 2022-05-04 2022-06-01 2022-06-15 2022-06-23 2022-06-23 The items due on 2022-06-23 show on the calendar on 2022-06-22. The one due on 2022-06-15 appears on the calendar on 2022-06-14. The rest appear on the 14th as well, but each of with a time-due matching the time I imported the file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136039|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136071&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Thanks! I hadn't thought about overdues! I was thinking about the overdue and it seems to make sense that they should be all day events for "today". Does that make sense Owen? Here is a new edition of the patch. The item's are already overdue so (In reply to Owen Leonard from comment #15)
Using your ICS file gave me the same result as you show. Here's some new information about my testing, though. Here's the due dates in the account I'm teting:
2022-01-01 2022-05-04 2022-06-01 2022-06-15 2022-06-23 2022-06-23
The items due on 2022-06-23 show on the calendar on 2022-06-22. The one due on 2022-06-15 appears on the calendar on 2022-06-14.
The rest appear on the 14th as well, but each of with a time-due matching the time I imported the file.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #17)
it seems to make sense that they should be all day events for "today".
Yes, that makes perfect sense to me. Confusing when I'm thinking in terms of being technically correct but logical from the user's point of view. What about the 2022-06-23 due date showing up on 2022-06-22? An item without a time due is due at midnight, which implies to me that the calendar should express the idea that the user has all day on the due date to turn it in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136072&action=edit ICS file from Kyle's testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136072|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136073&action=edit Screenshot from Kyle's testing 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- I think we are in agreement. If an item is due on 2022-06-23 at 23:59, it should show as an all day event for June 23, right? That appears to be how this latest patch is behaving for me: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136073 Is it off by a day for you? (In reply to Owen Leonard from comment #18)
(In reply to Kyle M Hall from comment #17)
it seems to make sense that they should be all day events for "today".
Yes, that makes perfect sense to me. Confusing when I'm thinking in terms of being technically correct but logical from the user's point of view.
What about the 2022-06-23 due date showing up on 2022-06-22? An item without a time due is due at midnight, which implies to me that the calendar should express the idea that the user has all day on the due date to turn it in.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #21)
That appears to be how this latest patch is behaving for me
It's not how it's working for me. Here's an example from the ICS file: BEGIN:VEVENT DESCRIPTION:Your copy of The best American comics 2010 / (barcode 320000002 00268) is due back at the library today DTSTAMP:20220614T172816Z DTSTART:20220622 SUMMARY:The best American comics 2010 / is due UID:issue-329@localhost END:VEVENT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Owen, so your still seeing the events as being in the DTSTART date, but at the DTSTAMP time? (In reply to Owen Leonard from comment #22)
(In reply to Kyle M Hall from comment #21)
That appears to be how this latest patch is behaving for me
It's not how it's working for me. Here's an example from the ICS file:
BEGIN:VEVENT DESCRIPTION:Your copy of The best American comics 2010 / (barcode 320000002 00268) is due back at the library today DTSTAMP:20220614T172816Z DTSTART:20220622 SUMMARY:The best American comics 2010 / is due UID:issue-329@localhost END:VEVENT
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136071|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136074&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Owen, can you give this latest version a try? I've learned a lot about the ical format today! ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- My calendar still thinks things are off by a day. Items due on 2022-06-23 are still on 2022-06-22. An item due today, 2022-06-15, appears on 2022-06-14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136074|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136094&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- We are almost there! Owen, I think this one will fix that! (In reply to Owen Leonard from comment #26)
My calendar still thinks things are off by a day. Items due on 2022-06-23 are still on 2022-06-22. An item due today, 2022-06-15, appears on 2022-06-14.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136094|0 |1 is obsolete| | --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136095&action=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #28)
I think this one will fix that!
Looks good, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please don't forget to run the QA script. * Commit title does not start with 'Bug XXXXX: ' - 14929d1fe5f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136095|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138890&action=edit Bug 30927: Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jandrews@washoecounty.us --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 18563 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org