[Bug 30294] New: Rename Koha::Recall->* used relationship names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Bug ID: 30294 Summary: Rename Koha::Recall->* used relationship names Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Our coding guidelines are not quite precise regarding this, but in order to make accessors for related objects embeddable/searchable on the REST API, the relationships should share the name with the method, as the 'sub biblio' example in the guidelines: https://wiki.koha-community.org/wiki/Coding_Guidelines#Koha::Object.28s.29 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131670&action=edit Bug 30294: Rename Koha::Recall->* used relationship names This patch renames the underlaying relationship names used in the 'patron' and 'library' subs so they are more clearly prefetchable and also enabling them to be embeddable and searchable through an eventual API route for recalls. To test: 1. Apply the patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Recall* => SUCCESS: Tests pass, nothing really changes 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131670|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131854&action=edit Bug 30294: Rename Koha::Recall->* used relationship names This patch renames the underlaying relationship names used in the 'patron' and 'library' subs so they are more clearly prefetchable and also enabling them to be embeddable and searchable through an eventual API route for recalls. To test: 1. Apply the patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Recall* => SUCCESS: Tests pass, nothing really changes 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131854|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131964&action=edit Bug 30294: Rename Koha::Recall->* used relationship names This patch renames the underlaying relationship names used in the 'patron' and 'library' subs so they are more clearly prefetchable and also enabling them to be embeddable and searchable through an eventual API route for recalls. To test: 1. Apply the patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Recall* => SUCCESS: Tests pass, nothing really changes 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Bug 30294 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Bug 30294 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Bug 30294 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org