[Bug 18598] New: Quick add form doesn't clear values when switching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Bug ID: 18598 Summary: Quick add form doesn't clear values when switching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |3534 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63445&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- I can reproduce the behaviour without patch. With patch, clearing works as described. However, with patch applied the values e.g. for surname are no longer transferred between the two forms. If I enter a surname AAA in quick add form and switch to full form, surname is empty. If then in full form I enter BBB as surname and switch back to quick add form, there is still AAA. Switching back to full form shows BBB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63445|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63554&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Yeah, I removed one too many lines in that first patch ( meant to remove the if condtiion, removed the whole block ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63554|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 63556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63556&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63556|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63638&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org