[Bug 18596] New: Quick add form duplicating password confirm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Bug ID: 18596 Summary: Quick add form duplicating password confirm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If password is in BorrowerMandatoryField we end up with two confirm fields - the test for matching and copying the field is unneccessary since we copy all required fields anyways. To recreate: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - Confirm password twice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63425&action=edit Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3534 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63425|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63426&action=edit Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63426|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63447&action=edit [SIGNED-OFF] Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required Signed-off-by: Peggy Thrasher <p.thrasher@dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63447|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63449&action=edit [SIGNED-OFF] Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- My brain scratched just after the first line: var passwd_mandatory = [% IF mandatorypassword %]0[% ELSE %]1[% END %]; I'd suggest to not use a JS var and simply: [% UNLESS mandatorypassword %] if( input_label == 'password' ) $("#entryform label[for='password2']").parent().clone().appendTo("#quick_add_list"); [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63555&action=edit Bug 18596 (QA Followup) Use TT in a less awkward way -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63449|0 |1 is obsolete| | Attachment #63555|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63616&action=edit Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org