[Bug 12165] New: Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Bug ID: 12165 Summary: Add description of charges (bug 2546) to Bootstrap OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr It looks like we forgot to fix the bootstrap templates in bug 2546: Copying test plan from the other bug: The descriptions for charges are stored in English in the DB (accountlines.description). So they are not translatable. This patch removes the descriptions automatically added and generates the string in the template. Test plan: 1/ Execute the updatedatabase entry. 2/ Verify in the following pages the description is consistent: - members/pay.pl?borrowernumber=XXXX - members/boraccount.pl?borrowernumber=XXXX - opac-account.pl 3/ Launch the translate script and update the po files in order to translate the new strings. 4/ Verify the strings are translated in the interface. The database bits for this are done, we only need to update the templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2546 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27821&action=edit Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11573 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 27879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27879&action=edit [Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27821|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28100&action=edit Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28101&action=edit Bug 12165: Display record title The code introduced by bug 2546 uses an undefined variable (line.title). It should be ACCOUNT_LINE.title. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27879|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master and 3.16.x. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11573 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org