http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 33608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33608&action=edit Bug 13262 - Add parameters to XSLT Handler transform method This patch adds an optional hashref argument to the XSLT_Handler transform() method. It allows you to send key => value pairs parameters to the XML::LibXSLT object, which you can reference in a XSLT via <xsl:param name="XXX" />. The parameter value is evaluated as an XPath query, so you can only pass quoted strings (i.e. "'test'") or numbers. Otherwise, the XSLT engine will interpret it as a Xpath query and will run it on the XML that you're transforming. The most common use case is sending strings to a XSLT. In my case, this is an OAI-PMH identifier that comes in a OAI response but not the actual metadata. See the following link from the official POD: http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters _TEST PLAN_ 1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass, you should be free to sign off. Feel free to inspect the last test in XSLT_Handler.t and the XSL in test04.xsl to see how it works. If you really want to be thorough, you could write your own test cases using mine as an example. Alternatively, you could go into C4::XSLT, and try to pass a value to a parameter in the search results or the detail page, but that might be a bit over the top. It's a pretty simple patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- All tests successful. Files=1, Tests=26, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.07 cusr 0.00 csys = 0.10 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to M. de Rooy from comment #5)

Maybe we should just be pragmatic here and replace the lines:

require XML::LibXML; my $dom = XML::LibXML->load_xml(string => $output); my $result = $dom->find( '/just_a_tagname' );

by a simple test like index($output,'this is a test')>0

LibXML uses overloading in XML::LibXML::Literal (and others) called from XML::LibXML::Node. Debugging this stuff seems much harder than just simplifying the test..

Maybe. Using index(), while not as exact, might be "good enough". However, I'm rather intrigued that Kyle is getting errors while you (Marcel) and I are not. I have no idea why it warned "left argument in overloaded package XML::LibXML::NodeList" when it should've been a XML::LibXML::Literal which would've magically stringified. Maybe rather than using index(), we should look into why Kyle is getting that problem though. The answer will determine the solution. If it's an issue of the overloading not working as expected, it would probably be an idea to go with: ok($result->value() eq 'this is a test', 'test name'); However, that still won't work if Kyle really is getting a NodeList back instead of a Literal. Kyle: Could you do a Data::Dumper($result) and tell us what you get? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33609|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 33967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33967&action=edit Bug 13262 - Add parameters to XSLT Handler transform method This patch adds an optional hashref argument to the XSLT_Handler transform() method. It allows you to send key => value pairs parameters to the XML::LibXSLT object, which you can reference in a XSLT via <xsl:param name="XXX" />. The parameter value is evaluated as an XPath query, so you can only pass quoted strings (i.e. "'test'") or numbers. Otherwise, the XSLT engine will interpret it as a Xpath query and will run it on the XML that you're transforming. The most common use case is sending strings to a XSLT. In my case, this is an OAI-PMH identifier that comes in a OAI response but not the actual metadata. See the following link from the official POD: http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters _TEST PLAN_ 1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass, you should be free to sign off. Feel free to inspect the last test in XSLT_Handler.t and the XSL in test04.xsl to see how it works. If you really want to be thorough, you could write your own test cases using mine as an example. Alternatively, you could go into C4::XSLT, and try to pass a value to a parameter in the search results or the detail page, but that might be a bit over the top. It's a pretty simple patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33967|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33978&action=edit Bug 13262 - Add parameters to XSLT Handler transform method This patch adds an optional hashref argument to the XSLT_Handler transform() method. It allows you to send key => value pairs parameters to the XML::LibXSLT object, which you can reference in a XSLT via <xsl:param name="XXX" />. The parameter value is evaluated as an XPath query, so you can only pass quoted strings (i.e. "'test'") or numbers. Otherwise, the XSLT engine will interpret it as a Xpath query and will run it on the XML that you're transforming. The most common use case is sending strings to a XSLT. In my case, this is an OAI-PMH identifier that comes in a OAI response but not the actual metadata. See the following link from the official POD: http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters _TEST PLAN_ 1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass, you should be free to sign off. Feel free to inspect the last test in XSLT_Handler.t and the XSL in test04.xsl to see how it works. If you really want to be thorough, you could write your own test cases using mine as an example. Alternatively, you could go into C4::XSLT, and try to pass a value to a parameter in the search results or the detail page, but that might be a bit over the top. It's a pretty simple patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Would be interesting if it also works for Kyle now :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- prove -v t/db_dependent/XSLT_Handler.t t/db_dependent/XSLT_Handler.t .. 1..26 ok 1 - Testing creation of handler object No XSLT file passed. at Koha/XSLT_Handler.pm line 322. ok 2 - Engine returns error on no file XSLT file not found. at Koha/XSLT_Handler.pm line 322. ok 3 - Engine returns error on bad file ok 4 - Test on invalid refresh ok 5 - Found my test stylesheet test01.xsl No string to transform. at Koha/XSLT_Handler.pm line 322. ok 6 - Engine returns error on undefined text Error while parsing input: Empty String at Koha/XSLT_Handler.pm line 179. ok 7 - Engine returns error on empty string Error while parsing input: :1: parser error : Start tag expected, '<' not found abcdef ^ ok 8 - Engine returns error on non-xml Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b <a></b> ^ ok 9 - Engine returns error on malformed xml Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b <a></b> ^ ok 10 - Engine respects do_not_return_source==1 Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b <a></b> ^ ok 11 - Second engine respects it too Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b <a></b> ^ ok 12 - Engine respects do_not_return_source==0 ok 13 - Test on valid refresh ok 14 - Test on repeated refresh ok 15 - Engine returned no error for xml_1 ok 16 - No real change expected for xml_1 ok 17 - Engine returned no error for xml_2 ok 18 - Saw the expected change for xml_2 ok 19 - Found my test stylesheet test02.xsl Error while parsing stylesheet: compilation error: file /var/lib/koha/kohaqa/kohaclone/t/db_dependent/XSLT_Handler/test02.xsl element variable redefinition of global variable redefine at Koha/XSLT_Handler.pm line 274. ok 20 - Engine returned error for parsing bad xsl ok 21 - Error string contains text ok 22 - Found my test stylesheet test03.xsl ok 23 - Unexpected error on transform with third xsl ok 24 - Final test on clearing cache ok 25 - Found my test stylesheet test04.xsl ok 26 - Successfully injected string into XSLT parameter/variable ok All tests successful. Files=1, Tests=26, 0 wallclock secs ( 0.03 usr 0.02 sys + 0.10 cusr 0.01 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33978|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34915&action=edit [PASSED QA] Bug 13262 - Add parameters to XSLT Handler transform method This patch adds an optional hashref argument to the XSLT_Handler transform() method. It allows you to send key => value pairs parameters to the XML::LibXSLT object, which you can reference in a XSLT via <xsl:param name="XXX" />. The parameter value is evaluated as an XPath query, so you can only pass quoted strings (i.e. "'test'") or numbers. Otherwise, the XSLT engine will interpret it as a Xpath query and will run it on the XML that you're transforming. The most common use case is sending strings to a XSLT. In my case, this is an OAI-PMH identifier that comes in a OAI response but not the actual metadata. See the following link from the official POD: http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters _TEST PLAN_ 1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass, you should be free to sign off. Feel free to inspect the last test in XSLT_Handler.t and the XSL in test04.xsl to see how it works. If you really want to be thorough, you could write your own test cases using mine as an example. Alternatively, you could go into C4::XSLT, and try to pass a value to a parameter in the search results or the detail page, but that might be a bit over the top. It's a pretty simple patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Things changed since this one got passed, please rebase so I can push this nice enhancement. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Created attachment 35566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35566&action=edit Bug 13262 - Add parameters to XSLT Handler transform method This patch adds an optional hashref argument to the XSLT_Handler transform() method. It allows you to send key => value pairs parameters to the XML::LibXSLT object, which you can reference in a XSLT via <xsl:param name="XXX" />. The parameter value is evaluated as an XPath query, so you can only pass quoted strings (i.e. "'test'") or numbers. Otherwise, the XSLT engine will interpret it as a Xpath query and will run it on the XML that you're transforming. The most common use case is sending strings to a XSLT. In my case, this is an OAI-PMH identifier that comes in a OAI response but not the actual metadata. See the following link from the official POD: http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters _TEST PLAN_ 1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass, you should be free to sign off. Feel free to inspect the last test in XSLT_Handler.t and the XSL in test04.xsl to see how it works. If you really want to be thorough, you could write your own test cases using mine as an example. Alternatively, you could go into C4::XSLT, and try to pass a value to a parameter in the search results or the detail page, but that might be a bit over the top. It's a pretty simple patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35685&action=edit Bug 13262: (QA followup) fix duplicate variable definition Running $ prove t/db_dependent/XSLT_Handler.t raises a couple warnings because of variable redefinitions. This small patch fixes that. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #19)

Patch pushed to master.

Thanks David! It opens us for interesting improvements.

Thanks, Tomas! I hope so! I think it would be interested to try XML::LibXSLT->register_function($uri, $name, $subref) as well. I use this locally for a few XSLT mods, and it works rather nicely. It doesn't require any mods to the Koha::XSLT_Handler either. You just "use XML::LibXSLT", register a function, and you're good to go! -- You are receiving this mail because: You are watching all bug changes.