[Bug 12944] New: There is no way to search orders by creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Bug ID: 12944 Summary: There is no way to search orders by creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org There is a 'authorisedby' DB field in the aqbasket table but the interface does not provide any way to search orders using this field. This field is automatically filled with the borrowernumber of the basket's creator. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31682&action=edit Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31683&action=edit Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31682|0 |1 is obsolete| | --- Comment #3 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31824&action=edit Bug 12944: Refactor the patron autocomplete I've applied the patch against master 3.17.00.025 Everything is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31683|0 |1 is obsolete| | --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31825&action=edit Bug 12944: Search orders by basket creator -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31824|0 |1 is obsolete| | Attachment #31825|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31987&action=edit [PASSED QA] Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31988&action=edit [PASSED QA] Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31989&action=edit [PASSED QA] Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32922&action=edit Bug 12944 [Patron lists follow-up] There is no way to search orders by creator This bug modifies not just the order search form but also the patron lists feature, making use of the new script for building a patron autocomplete form. However, the test plan does not specify that the patron lists form be tested as well, and it doesn't work. This patch corrects a minor flaw which broke the patron search autocomplete when adding patrons to a patron list. To test, create a new patron list if necessary. Click the "add patrons" button to add patrons to the list. In the patron search form type a partial patron name. You should get an autocomplete dropdown of existing patrons. Selecting one should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32922|0 |1 is obsolete| | --- Comment #9 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 32931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32931&action=edit Bug 12944 [Patron lists follow-up] There is no way to search orders by creator I've applied the 4 patches against master 3.17.00.035 The error that Owen mentioned in comment 8 is properly fixed by the 4-th patch. Everything is OK. So I pass the patch to "Signed Off" status. [I release to bugzilla [and make obsolete] only the 4-th file "[Patron lists follow-up] There is no way to search orders by creator".] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After refreshing the page multiple times, there is still an erorr on the acq history page after a search: TypeError: $(...).autocomplete(...).data(...) is undefined http://localhost:8080/intranet-tmpl/js/autocomplete/patrons.js Line 20 I did an 'empty' search from the orders search tab at the top. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #11 from Paola Rossi <paola.rossi@cineca.it> --- NB. On patron list, there is a little redundancy in the removing patrons' options. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31987|0 |1 is obsolete| | Attachment #31988|0 |1 is obsolete| | Attachment #31989|0 |1 is obsolete| | Attachment #32931|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33197&action=edit Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33198&action=edit Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33199&action=edit Bug 12944 [Patron lists follow-up] There is no way to search orders by creator This bug modifies not just the order search form but also the patron lists feature, making use of the new script for building a patron autocomplete form. However, the test plan does not specify that the patron lists form be tested as well, and it doesn't work. This patch corrects a minor flaw which broke the patron search autocomplete when adding patrons to a patron list. To test, create a new patron list if necessary. Click the "add patrons" button to add patrons to the list. In the patron search form type a partial patron name. You should get an autocomplete dropdown of existing patrons. Selecting one should work correctly. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33200&action=edit Bug 12944: The autocomplete should only be applied for the form If it's the result view, the autocomplete should not be apply to the input element (it does not exist). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #10)
I did an 'empty' search from the orders search tab at the top.
Fixed! I also squashed the Kyle's patch (in order to avoid the creation and the deletion of a file in the git tree). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #11)
NB. On patron list, there is a little redundancy in the removing patrons' options.
Yes I agree, but not introduced by this patch. You can open a new bug report if you want. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 33197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33197 Bug 12944: Refactor the patron autocomplete Review of attachment 33197: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12944&attachment=33197) ----------------------------------------------------------------- Hi Jonathan, overall this looks good :) ::: koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js @@ +32,5 @@
+ }); +} + +function AddPatron( patron_name, value, container, input_name ) { + div = "<div id='borrower_" + value + "'>" + patron_name + " ( <a href='#' class='removePatron'> " + _("Remove") + " </a> ) <input type='hidden' name='" + input_name + "' value='" + value + "' /></div>";
But by moving the Javascript into a separate js file, the "Remove" will no longer be translatable. Could you please fix? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34781&action=edit Bug 12944: Fix regression on translating This patch fixes the translation for the "Remove" button. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35589&action=edit [PASSED QA] Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35590&action=edit [PASSED QA] Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35591&action=edit [PASSED QA] Bug 12944 [Patron lists follow-up] There is no way to search orders by creator This bug modifies not just the order search form but also the patron lists feature, making use of the new script for building a patron autocomplete form. However, the test plan does not specify that the patron lists form be tested as well, and it doesn't work. This patch corrects a minor flaw which broke the patron search autocomplete when adding patrons to a patron list. To test, create a new patron list if necessary. Click the "add patrons" button to add patrons to the list. In the patron search form type a partial patron name. You should get an autocomplete dropdown of existing patrons. Selecting one should work correctly. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35592&action=edit [PASSED QA] Bug 12944: The autocomplete should only be applied for the form If it's the result view, the autocomplete should not be apply to the input element (it does not exist). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35593&action=edit [PASSED QA] Bug 12944: Fix regression on translating This patch fixes the translation for the "Remove" button. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tested: - acq history search with different searches - patron lists patron search Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35698&action=edit Bug 12944: (QA followup) fix POD errors from koha-qa.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There is no way to search |Search for creator of an |orders by creator |order -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org